Repository navigation
Support selecting resources for deletion with bundle deploy --select - #7023
Merged
Merged
Conversation
andersrexdb
added a commit
that referenced
this pull request
Oct 12, 2026
Add the trailing PR link required by the changelog validation so the Changelog Preview workflow passes. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4251876
Top 6 slowest tests (at least 2 minutes):
|
andersrexdb
force-pushed
the
select-deletions
branch
from
October 15, 2026 09:46
aee21d0 to
30adca7
Compare
denik
reviewed
Oct 15, 2026
Contributor
|
Commit: Regression test reportSelected 6 changed tests (limit=20, 0 not selected) 12 tests: regression=6 unreleased=0 coverage=6 failing=0
TestAccept/bundle/select/deletion/DMS=: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): same output as main (1ea9041) TestAccept/bundle/select/deletion/DMS=true: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): same output as main (1ea9041) TestAccept/bundle/select/deletion_dependents/DMS=: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): same output as main (1ea9041) TestAccept/bundle/select/deletion_dependents/DMS=true: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): TestAccept/bundle/select/deletion_saved_plan/DMS=: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): same output as main (1ea9041) TestAccept/bundle/select/deletion_saved_plan/DMS=true: branch ✅ | main (1ea9041) ❌ | latest (v1.22.1) ❌main (1ea9041): latest (v1.22.1): same output as main (1ea9041) |
denik
reviewed
Oct 21, 2026
andersrexdb
force-pushed
the
select-deletions
branch
from
October 22, 2026 10:05
3f151b0 to
1c8d42e
Compare
Resolve --select selectors against the computed plan (Plan.FilterToSelected) instead of the config, so resources removed from config and planned for deletion can be selected like any other. The old ResolveSelect mutator is reduced to recording the select_used telemetry flag (renamed MarkSelectUsed). When a selected resource is being deleted, the plan's closure follows reverse dependency edges: its dependents are deleted too so none are left dangling, while its own dependencies are left untouched — mirroring bundle destroy. A deployed selection still follows forward edges to pull in its dependencies. Grants and permissions sub-nodes move with their parent in both directions. Deleting a resource whose dependent is still live (still in config, not itself being deleted) is an error before any API delete requests are sent. An invalid --select (a name in neither config nor state) is rejected before the predeploy script runs or any files are uploaded. When --plan is used alongside a --select that doesn't match the selectors the plan was built with, a warning is emitted. The plan serializes was_filtered and selectors so a pre-filtered plan file can be passed to bundle deploy --plan without re-specifying --select. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Remove the WasFiltered and Selectors plan fields and the --plan + --select warning they supported, per review: --plan keeps ignoring --select as before, and encoding the selection in the plan is left for a follow-up. Stop sorting the delete requests in the deletion_dependents acceptance test. --sort orders by raw job ID, which is random on a real workspace and made the test flaky in cloud runs; dependents are deleted first, so the order is stable. Co-authored-by: Isaac <no-reply@databricks.com>
andersrexdb
force-pushed
the
select-deletions
branch
from
October 27, 2026 16:43
1c8d42e to
4251876
Compare
denik
approved these changes
Oct 27, 2026
| // e.g. "jobs.my_job") plus their transitive dependencies as recorded in each | ||
| // entry's DependsOn field. Nodes not reachable from the selected set are removed. | ||
| func (p *Plan) FilterToSelected(selected []string) { | ||
| // ResolveSelectors maps each --select selector to its plan key ("resources.type.name") |
Contributor
There was a problem hiding this comment.
There seems to be minor overlap with ResolveKey https://github.com/databricks/cli/pull/7128/changes
maybe we should rewrite ResolveKey users to use this function (not required, just an idea).
Contributor
Author
There was a problem hiding this comment.
That true, but ResolveKey returns the config object and can't see state-only deletions, so I'd keep them separate here and maybe address in follow-up.
Collaborator
Integration test reportCommit: 3909f85
12 interesting tests: 12 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve
--selectselectors against the computed plan (Plan.FilterToSelected) instead of the config, so resources removed from config and planned for deletion can be selected like any other. The oldResolveSelectmutator is reduced to recording theselect_usedtelemetry flag (renamedMarkSelectUsed).When a selected resource is being deleted, the plan's closure follows reverse dependency edges: its dependents are deleted too so none are left dangling, while its own dependencies are left untouched — mirroring
bundle destroy. A deployed selection still follows forward edges to pull in its dependencies. Grants and permissions sub-nodes move with their parent in both directions.Deleting a resource whose dependent is still live (still in config, not itself being deleted) is an error before any API delete requests are sent. An invalid
--select(a name in neither config nor state) is rejected before the predeploy script runs or any files are uploaded.Tests
Added unit tests (
TestFilterToSelected_*) and acceptance tests underacceptance/bundle/select.This pull request and its description were written by Isaac.