Repository navigation
Use synctest.Sleep in SSH tests - #7118
Merged
Merged
Conversation
Go 1.27 adds synctest.Sleep, which is equivalent to time.Sleep followed by synctest.Wait. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
marked this pull request as ready for review
October 20, 2026 10:01
pietern
enabled auto-merge
October 20, 2026 10:01
Collaborator
Integration test reportCommit: cefc748
Top 3 slowest tests (at least 2 minutes):
|
rugpanov
approved these changes
Oct 22, 2026
Collaborator
Integration test reportCommit: b066bb2
9 interesting tests: 9 flaky
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
Integration test reportCommit: b066bb2
541 interesting tests: 464 MISS, 77 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace
time.Sleep(d)followed bysynctest.Wait()withsynctest.Sleep(d)(Go 1.27) at the 26 places in theexperimental/sshtests where they appear together.This pull request and its description were written by Isaac.