Repository navigation
Add support for configuring app health_check via bundle config - #7152
Open
arushiagarwal-db wants to merge 7 commits into
Open
arushiagarwal-db wants to merge 7 commits into
arushiagarwal-db wants to merge 7 commits into
Conversation
Adds `health_check` (path, timeout_seconds) to the inline app `config` block and passes it to the Apps Deploy API as `health_check`. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=4 unreleased=0 coverage=0 failing=0
TestAccept/bundle/refschema/DMS=: branch ✅ | main (2f505a7) ❌ | latest (v1.22.1) ❌main (2f505a7): latest (v1.22.1): TestAccept/bundle/refschema/DMS=true: branch ✅ | main (2f505a7) ❌ | latest (v1.22.1) ❌main (2f505a7): latest (v1.22.1): TestAccept/bundle/resources/apps/inline_config/DMS=: branch ✅ | main (2f505a7) ❌ | latest (v1.22.1) ❌main (2f505a7): latest (v1.22.1): same output as main (2f505a7) TestAccept/bundle/resources/apps/inline_config/DMS=true: branch ✅ | main (2f505a7) ❌ | latest (v1.22.1) ❌main (2f505a7): latest (v1.22.1): same output as main (2f505a7) |
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 3a187f6
|
…nline-health-check
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
health_checkto the inline appconfigblock for apps in bundle config:The value is passed to the Apps Deploy API's new
health_checkfield (path,timeout). The fields matchhealth_checkin app.yaml (path,timeout_seconds), sodatabricks apps importalso inlineshealth_checkfrom an existing app.yaml. The direct engine readshealth_checkback from the active deployment for drift detection, the same way it does forcommandandenv.Why
This follows #4271 (inline
command/env). It lets users set the deploy-time health check per target in bundle config, without keeping it in a separate app.yaml.Tests
acceptance/bundle/resources/apps/inline_configacceptance test with ahealth_checkand a/healthroute in the test app.TestBuildAppDeploymentWithValueFromandTestInlineAppConfigFileFieldPriorityunit tests.Supersedes #7081 (reopened from a branch in this repo so CI runs).
This pull request and its description were written by Isaac.