Repository navigation
acc: split vector search tests between direct and DMS - #7176
Merged
Merged
Conversation
…MS variant The initial deploy spends ~20 min waiting for the endpoint and index on cloud, and DMS does not affect recreation, so the DMS=true variant doubled the nightly cost without adding coverage. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 16 changed tests (limit=20, 0 not selected) 16 tests: regression=0 unreleased=0 coverage=16 failing=0
|
Co-authored-by: Isaac <no-reply@databricks.com>
denik
changed the title
Collaborator
Integration test reportCommit: 83227bc
Top 23 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 26, 2026 11:08
denik
enabled auto-merge
October 26, 2026 11:09
andrewnester
approved these changes
Oct 26, 2026
andrewnester
left a comment
andrewnester
left a comment
Contributor
There was a problem hiding this comment.
Do we have any vector search test that runs on DMS=true? If ot, we may run into a situation where backend rejects vector search resource but we don't have it covered (this is prompted by internal_immutable_snapshot resource not being handled by DMS)
andrewnester
disabled auto-merge
October 26, 2026 12:24
Contributor
Author
good point - I'll split them 50/50 between direct and DMS. |
Co-authored-by: Isaac <no-reply@databricks.com>
denik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Each vector search test now runs a single DMS variant instead of both:
EnvMatrix.DMS = [""]invector_search_indexes/test.tomlandvector_search_endpoints/test.toml, overridden to["true"]in 8 of the 16 tests. Of the 6 tests that run on cloud, 3 use each variant (endpoints:basicdirect,drift/recreated_same_nameDMS; indexes:basicandrecreate/embedding_dimensiondirect,grants/selectandschema_normalizationDMS).Why
Most of the cloud time in these tests is endpoint/index provisioning (e.g.
recreate/embedding_dimensionspends ~20-25 min on AWS/Azure in the initial deploy; the recreate itself takes ~10s). Running every test under both variants doubled that cost; splitting keeps both paths covered for each resource type.Tests
Regenerated
out.test.tomlfiles; all 16 pass locally against the testserver.This pull request and its description were written by Isaac.