Repository navigation
Conversation
bundle/invariant/no_drift with genie_space.yml.tmpl flakes on cloud: after an update that clears the description, the next GET still returns the old one. Replay the direct engine's create/update requests with plain genie commands and poll GET to tell a stale read from a lost update. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
Collaborator
Integration test reportCommit: bf5dcc5
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New
cmd/workspace/genie-clear-descriptiontest: replays the create/update requests the direct engine sends for a genie space (plaingenie create-space/update-space/get-space, no bundles), then polls GET for ~30s. Each round is classified as CONVERGED, STALE_READ (old description, then cleared for good), LOST_UPDATE (cleared, then old description returns) or NOT_APPLIED; anything other than CONVERGED prints the timeline (description, serialized_space version, etag per poll). Rounds vary the delay between create and update (0/3/6/10s on cloud).Why
bundle/invariant/no_drift/DMS=/INPUT_CONFIG=genie_space.yml.tmpl/READPLAN=flaked on AWS in nightly 40247677044: after the field-removal deploy cleareddescription, the next plan still read the old value. The CLI force-sendsdescription: ""(#6789), so it's either a stale read or the backend losing the update (e.g. to the async serialized_space v1 -> v2 migration). This test tells which.Tests
Passes locally against the testserver. Cloud run pending.
This pull request and its description were written by Isaac.