Repository navigation
Conversation
On Windows CI, os.Remove on a file that was just written can fail with "The process cannot access the file because it is being used by another process" while another process still holds it open. This failed TestSyncIncrementalFileOverwritesFolder (azure windows, 2026-10-25) and the subsequent waitForCompletionMarker then timed out. Retry the removal for a bounded time so the test does not depend on that handle being released immediately. Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
October 26, 2026 09:02
denik
enabled auto-merge
October 26, 2026 09:10
Collaborator
Integration test reportCommit: 6aa1472
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
testfile.TestFile.Removeretriesos.Removeevery 100ms for up to 10s before failing.Why
integration/cmd/sync.TestSyncIncrementalFileOverwritesFolderflaked on azure-windows in nightly 40191415337:remove C:\...\foo\bar.txt: The process cannot access the file because it is being used by another process.(sync_test.go:399), after which the sync wait timed out. Sync closes the file before reporting completion, so the holder is most likely an external process (antivirus/indexer) holding the just-written file briefly.Tests
go test ./libs/sync/... ./cmd/sync/...; integration test to run in CI.This pull request and its description were written by Isaac.