Repository navigation
acc: Collapse the test table in the regression report comment - #7181
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
The table has a row per test variant, often hundreds, which buries the failure details below it. It now sits in a <details> block summarized by the counts line. The workflow trims an oversized report by splitting it at <details>, so it now always keeps the first block, the table. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
can you add before/after as a comment there? |
Contributor
This example seems to have an issue with test selection in general, it should not have selected all auto-migrate tests. (Does not invalidate this PR, it could still be useful) |
Collaborator
Integration test reportCommit: 5d0fedc
Top 7 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The regression report comment now puts the per-test table in a
<details>block, with the counts line (659 tests: regression=15 ...) as its summary.The workflow trims an oversized report by splitting it at
<details>, so it now always keeps the first block (the table) and drops only failure details.Why
The table has a row per test variant, often hundreds (e.g. #7094), which buries the failure details below it.
Tests
TestRenderRegressionReportto assert the table is wrapped.<details>tags stay balanced.This pull request and its description were written by Isaac.