Repository navigation
Conversation
*Why*: * Users must fold each job, pipeline and task node by hand; large bundles make the view cluttered (#1698). *What:* * Register `dabsResourceExplorerView` with `window.createTreeView` and `showCollapseAll: true`, which adds VS Code's native Collapse All icon to the view title bar. * The default expand state of the tree is unchanged. *Verification:* * `tsc --noEmit`: same error set as `origin/main` (pre-existing worktree artifacts only); e2e tsconfig compiles clean. * ESLint and Prettier clean on the changed files. * New e2e step in `refresh_resource_explorer_on_yml_change.e2e.ts` clicks Collapse All and checks that only the `Jobs` header stays visible; runs in CI. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
🤖 Integration tests running for |
*Why*: * Clicking the centre of the view to reveal title actions can land on a tree row and toggle it, so the step could pass even if Collapse All did nothing. * The step checked only the root, not nested nodes. *What:* * Hover the view header to reveal the action, and re-fetch and click it inside the retry loop. * After Collapse All, expand `Jobs` and assert that the job node stays collapsed. *Verification:* * e2e `tsc`, ESLint and Prettier clean on the changed file; the step itself runs in CI. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
🤖 Integration tests running for |
*Why*: * The check required exactly one visible `Jobs` row, which breaks if the fixture gains another resource type. * The hover target used a hard-coded `.pane-header` class instead of the library's versioned locator. *What:* * Wait until no visible row shows the job, instead of matching an exact row list. * Hover via `ViewSection.header$`. *Verification:* * e2e `tsc`, ESLint and Prettier clean on the changed file; the step itself runs in CI. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
🤖 Integration tests ❌ failed for |
*Why*: * `getViewSection` collapses every other section with wdio's `ViewSection.collapse()`, which clicks the centre of the pane header. * The new Collapse All icon widens the Bundle Resource Explorer title-bar toolbar, so in the CI sidebar the toolbar covers the header centre. VS Code ignores header clicks that land on the toolbar, the section stays expanded, and `collapse()` times out — failing nearly every e2e spec at "wait for extension activation" / "wait for connection". *What:* * Add a `collapseViewSection` helper that clicks the section's `.twisty-container` and waits for it to collapse; use it in `getViewSection`. *Verification:* * CI integration logs: every failing shard hit "waitUntil condition timed out after 1000ms" on the Bundle Resource Explorer header click (aria-expanded stayed true); last night's nightly on main has none. * e2e `tsc`, ESLint and Prettier clean; the integration run on this commit is the real check. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
🤖 Integration tests running for |
*Why*: * The nested-collapse check could pass without Collapse All if the previous step ever stopped expanding the job. *What:* * Assert that the job node is expanded before clicking Collapse All. * Note why `collapseViewSection` skips hidden headers. *Verification:* * e2e `tsc`, ESLint and Prettier clean; the integration run on this commit is the real check. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
🤖 Integration tests ❌ failed for |
rugpanov
marked this pull request as ready for review
October 27, 2026 14:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Bundle Resource Explorer had no way to collapse the tree. Users folded each job, pipeline, and "Tasks" node by hand. Large bundles made the view cluttered. Closes #1698.
dabsResourceExplorerViewwithwindow.createTreeView(..., {showCollapseAll: true}), notregisterTreeDataProvider.Tests
refresh_resource_explorer_on_yml_change.e2e.ts:Jobsand checks that the job node stays collapsed. This proves that the button collapses nested nodes, not only the root.getViewSectionnow collapses the other view sections with a click on the twisty. wdio'scollapse()clicks the header centre. The wider Bundle Resource Explorer toolbar covers that point in CI, and VS Code ignores clicks on the toolbar. Without this change, almost every e2e spec timed out.tsc, ESLint, and Prettier pass on the changed files.Known limitations
JobsandPipelinesheaders. To see the list of resources, the user expands a header again.TaskTreeNodeids include the job id, which changes after the first deploy. Manual folding onmainhas the same behavior.This pull request and its description were written by Isaac.