Repository navigation
fix(deploy): disable idleTimeout when removed or set to 0 in yaml - #170
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: disabling idleTimeout when it is removed or set to 0 in YAML. It matches the implementation and tests. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
UpdateFunction keeps the online value when the field is omitted, and the server rejects 0 (min 300), so removing idleTimeout from s.yaml never took effect. -1 is the only accepted value that disables it, matching the state the console writes when the toggle is off. - add idleTimeout: -1 to FC_RESOURCES_EMPTY_CONFIG so an unset prop clears the online value like other empty configs - normalize idleTimeout 0/null in props to -1 during deploy - add unit tests for unset/0/null/configured idleTimeout - bump component version to 0.1.27
f8f13d8 to
3d8ded4
Compare
1 participant
idleTimeoutwhen the prop is removed from s.yaml: the component previously omitted the field from the update request, andUpdateFunctiontreats an omitted field as "keep old value", so the removal was silently ignoredidleTimeout: -1toFC_RESOURCES_EMPTY_CONFIGso an unset prop resets the online value like other empty configs (-1is the disable value, matching the state the console writes when the toggle is off)idleTimeout: 0/nullin props to-1during deploy, since the server rejects0(IdleTimeout is too small (min: 300)) and-1is the only accepted value that disables itSummary by CodeRabbit
0ornullare now handled consistently during function deployment. When no timeout is configured, the default disables delayed release of elastic instances; other configured values are preserved.