fix: resolve test conflicts with .env environment variables - #526
Open
cometjc wants to merge 1 commit into
Open
Conversation
- Add Jest global setup/teardown hooks to backup and restore .env file - Clear OCO_ environment variables during test execution - Modify test resetEnv function to prevent OCO_ env vars from interfering - Prevent .env file from interfering with test expectations This fixes the issue where tests were failing due to environment variables from the user's .env file overriding the expected default config values.
di-sukharev
requested changes
Aug 20, 2026
|
|
||
| // Backup .env file if it exists and clear related env vars | ||
| if (fs.existsSync(envPath)) { | ||
| fs.renameSync(envPath, backupPath); |
Owner
There was a problem hiding this comment.
Do not rename the working .env file. If Jest crashes or is killed before globalTeardown, the file remains at .env.test-backup, and concurrent runs will race. The tests already support temporary globalPath and envPath values; clear OCO_* variables in setup and create fixtures in a temporary directory without touching the developer file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes test failures caused by environment variables from the user's .env file interfering with test expectations.
Changes Made
globalSetupandglobalTeardownto backup and restore the .env file during testingresetEnvfunction to avoid restoring OCO_ environment variablesProblem Solved
Previously, when users had OCO_ environment variables set in their .env file (like OCO_MODEL=gpt-5-mini, OCO_TOKENS_MAX_OUTPUT=8192), these would override the expected default values in tests, causing failures.
Solution
The fix ensures that:
This maintains backward compatibility while ensuring reliable test execution.