Skip to content

feat(deps): add undici dependency version 8.4.1 - #557

Open
TAYUN wants to merge 1 commit into
di-sukharev:masterfrom
TAYUN:feat/add-undici-dependency
Open

feat(deps): add undici dependency version 8.4.1#557
TAYUN wants to merge 1 commit into
di-sukharev:masterfrom
TAYUN:feat/add-undici-dependency

Conversation

@TAYUN

@TAYUN TAYUN commented Jun 12, 2026

Copy link
Copy Markdown

Summary

Add undici@8.4.1 as an explicit dependency.

Why

This project uses Agent, ProxyAgent, and setGlobalDispatcher from undici in the proxy setup logic.

According to the Undici documentation, these APIs are not provided by Node.js built-in fetch alone. Built-in fetch covers the standard request interface, but advanced networking features such as ProxyAgent, Socks5Agent, and MockAgent require the undici package directly.

Since OpenCommit uses ProxyAgent and setGlobalDispatcher to configure proxy behavior, undici should be declared explicitly in dependencies.

https://github.com/nodejs/undici

Changes

  • add undici@8.4.1 to dependencies

Verification

  • confirmed src/utils/proxy.ts imports and uses Agent, ProxyAgent, and setGlobalDispatcher from undici
  • confirmed pnpm build succeeds after adding the dependency

@di-sukharev di-sukharev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undici should indeed be a direct dependency because src/utils/proxy.ts imports it, but this version and the incomplete lockfile currently break both test jobs.

Comment thread package.json
"inquirer": "^9.1.4",
"openai": "^4.57.0",
"punycode": "^2.3.1",
"undici": "8.4.1",

@di-sukharev di-sukharev Aug 20, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci fails in this state because package-lock.json was not updated. In addition, undici@8.4.1 requires Node >=22.19.0, while the project CI runs on Node 20. Please use a version compatible with the supported runtime, or coordinate a Node upgrade, update the lockfile, and restore green CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants