Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused documentation corrections align with the provider behavior, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Updates the SQLite provider documentation to reflect current EF Core decimal support and SQL translations.
Changes:
- Separates supported decimal operations from the remaining query limitations.
- Adds EF Core 10.0 decimal
MaxandMinaggregate mappings. - Corrects Boolean string conversion and parameter names in date and angle conversions.
| File | Description |
|---|---|
| entity-framework/core/providers/sqlite/limitations.md | Clarifies decimal translation support and retains limitations for other unsupported types. |
| entity-framework/core/providers/sqlite/functions.md | Adds decimal aggregate mappings and corrects SQL translation examples. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQLite provider pages no longer matched what EF Core generates. Checked with Microsoft.EntityFrameworkCore.Sqlite 10.0.13.
Limitations
The query limitations listed
decimalamong the types whose comparison and ordering have to be evaluated on the client. EF Core translates them, as the Function Mappings page and the EF Core 9 and 10 what's new pages already say:decimalis now described with its translations.DateTimeOffset,TimeSpanandulongstay in the list: ordering by them throwsNotSupportedExceptionand comparing them isn't translated.Function mappings
group.Maxandgroup.Minover adecimalproperty translate toef_maxandef_min(EF Core 10.0, SQLite: implement MAX/MIN/ORDER BY fordecimalefcore#35606); the rows were missing.boolValue.ToString()translates toCASE WHEN @boolValue THEN 'True' ELSE 'False' END, notCAST(@boolValue AS TEXT), which would return0or1.dateTime.AddHours(value)used@dinstead of@value, anddouble.RadiansToDegrees(radians)used@dradiansinstead of@radians.