Skip to content

adapter.aasx: Skip conflicting files in failsafe mode - #675

Open
JavithNaseem-J wants to merge 1 commit into
eclipse-basyx:developfrom
JavithNaseem-J:fix/aasx-failsafe-duplicates
Open

JavithNaseem-J wants to merge 1 commit into
eclipse-basyx:developfrom
JavithNaseem-J:fix/aasx-failsafe-duplicates

Conversation

@JavithNaseem-J

Copy link
Copy Markdown

Problem

When two supplementary files have the same path but different contents, the AASX writer logs an error in failsafe mode but still writes the conflicting file.

This creates duplicate ZIP entries and can cause the original file contents to be lost when reading the package.

Fix

Add continue after logging the conflict in failsafe mode so the writer skips the duplicate supplementary file.

Strict mode continues to raise ValueError for conflicting files.

Testing

  • Added a regression test for conflicting supplementary files.
  • Verified the regression test fails before the fix and passes afterward.
  • Verified that the original file content is preserved.
  • Verified that strict mode raises ValueError.

Fixes #671

Copilot AI balanced review requested due to automatic review settings October 23, 2026 05:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants