Repository navigation
adapter.aasx: Skip conflicting files in failsafe mode - #675
Open
JavithNaseem-J wants to merge 1 commit into
Open
JavithNaseem-J wants to merge 1 commit into
JavithNaseem-J wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When two supplementary files have the same path but different contents, the AASX writer logs an error in failsafe mode but still writes the conflicting file.
This creates duplicate ZIP entries and can cause the original file contents to be lost when reading the package.
Fix
Add
continueafter logging the conflict in failsafe mode so the writer skips the duplicate supplementary file.Strict mode continues to raise
ValueErrorfor conflicting files.Testing
ValueError.Fixes #671