Repository navigation
CI: Fix sdk dependency in server-test job - #676
Merged
Merged
Conversation
Currently, there is no way to declare the `basyx-python-sdk` as dependency of the `server` package with matching version numbers, so the `pyproject.toml` defines only a lower constraint `basyx-python-sdk>=1.0.0` (see eclipse-basyx#592 for details). Previously, this lead in the `server-test` job to the situation, that `pip install .[dev]` installed the `sdk` again from PyPI, because the locally build `sdk` (`pip install ../sdk`) is flagged as version `0.1.dev1+g<sha>` and therefore does not fulfill the requirement. This is caused by the GitHub Action `actions/checkout` that by default only checks out the last commit, not including any tags, so `setuptools_scm` assigns the sdk a wrong version number. These changes apply the same workaround that we already used for the `server-static-analysis` job. It checks out the full depth of the repo, including the tags, so the `sdk` package is built with a version `>=1.0.0`. Fixes eclipse-basyx#662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to declare the
basyx-python-sdkas dependency of theserverpackage with matching version numbers, so thepyproject.tomldefines only a lower constraintbasyx-python-sdk>=1.0.0(see #592 for details).Previously, this lead in the
server-testjob to the situation, thatpip install .[dev]installed thesdkagain from PyPI, because the locally buildsdk(pip install ../sdk) is flagged as version0.1.dev1+g<sha>and therefore does not fulfill the requirement. This is caused by the GitHub Actionactions/checkoutthat by default only checks out the last commit, not including any tags, sosetuptools_scmassigns the sdk a wrong version number.These changes apply the same workaround that we already used for the
server-static-analysisjob. It checks out the full depth of the repo, including the tags, so thesdkpackage is built with a version>=1.0.0.Fixes #662