Repository navigation
server: only write the XML cursor attribute when there is a next page - #677
Open
qiaobochi040726-source wants to merge 1 commit into
Open
qiaobochi040726-source wants to merge 1 commit into
qiaobochi040726-source wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML pagination wrote the
cursorattribute unconditionally, so the last page came back withcursor="None"and a client following it sends?cursor=Noneand gets a 400. Now the attribute is only set when there is a next page, same as the JSON branch.Added two tests under
server/test/interfacesfor the last page and for a page that does have a next cursor.pytest testinserver/: 10 passed, 1 failed —test_shells_asset_ids.pyfails the same way on main, unrelated to this change.closes #673