Repository navigation
Added ARMv7-A TX_THREAD offset checks - #800
Open
JeewoongKim wants to merge 1 commit into
Open
JeewoongKim wants to merge 1 commit into
JeewoongKim wants to merge 1 commit into
Conversation
The ARMv7-A assembly uses hard-coded offsets to access TX_THREAD members. Changes to the structure layout could break these accesses. Added compile-time checks in the shared ARMv7-A source tree and regenerated the GNU and AC6 port copies. Built all seven GNU port and verified that an incorrect VFP offset causes a compilation failure. Assisted-by: ChatGPT (GPT-5.6 Sol)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the ARMv7-A portion of #577.
The ARMv7-A assembly uses hard-coded offsets to access
TX_THREADmembers.This change adds compile-time checks to catch mismatches when the structure layout changes.
The checker is added to shared ARMv7-A source tree and propagated to all seven Cortex-A
GNU and AC6 ports using
update.sh. The GNU CMake files are also updated to compile it.I built all seven GNU ports A{5, 7, 8, 9, 12, 15, 17} and confirmed that an incorrect VFP offset
(148 instead of 144) causes a compilation failure. The AC6 ports were not built.
I wrote this change by myself using the existing AI-generated Cortex-R52 offset checker (ports/cortex_r52/gnu/src/tx_port_offset_check.c) as a reference.
ChatGPT reviewed the ARMv7-A assembly to check whether all hard-coded
TX_THREADmember offsets were covered by the checker. I verified the findings against the assembly myself.
PR checklist