Repository navigation
fix(worker): keep tunnel cleanup consistent - #3
Merged
Merged
Conversation
augustoccesar
approved these changes
Sep 18, 2026
ostenbom
force-pushed
the
fix/tunnel-cleanup-consistency
branch
from
September 18, 2026 09:34
4f2b77a to
9d0c158
Compare
augustoccesar
pushed a commit
that referenced
this pull request
Oct 8, 2026
## Summary - delete a tunnel DNS record before deleting the Cloudflare tunnel - treat an already-missing DNS record as successful cleanup so retries remain idempotent ## Why The scheduled cleanup previously deleted the Cloudflare tunnel before looking up and deleting its DNS record. If the DNS lookup or deletion then failed, cleanup retained the `LINKUP_TUNNELS` KV entry even though the tunnel was already gone. Subsequent `linkup start` calls reused those stale credentials and cloudflared failed with `Unauthorized: Tunnel not found`. Performing DNS cleanup first ensures DNS failures leave the tunnel and KV record consistent. If tunnel deletion fails after DNS deletion, the next cleanup attempt tolerates the missing DNS record and retries the tunnel deletion. ## Validation - `cargo test -p linkup-worker` - `cargo clippy -p linkup-worker --all-targets -- -D warnings` - `cargo fmt --all -- --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The scheduled cleanup previously deleted the Cloudflare tunnel before looking up and deleting its DNS record. If the DNS lookup or deletion then failed, cleanup retained the
LINKUP_TUNNELSKV entry even though the tunnel was already gone. Subsequentlinkup startcalls reused those stale credentials and cloudflared failed withUnauthorized: Tunnel not found.Performing DNS cleanup first ensures DNS failures leave the tunnel and KV record consistent. If tunnel deletion fails after DNS deletion, the next cleanup attempt tolerates the missing DNS record and retries the tunnel deletion.
Validation
cargo test -p linkup-workercargo clippy -p linkup-worker --all-targets -- -D warningscargo fmt --all -- --check