Repository navigation
fix(hid-rp): bump hid-rp submodule to pick up missing <bit> include - #843
Merged
Merged
Conversation
hid/rdf/short_item.hpp uses std::bit_cast without including <bit>.
GCC pulls it in transitively, but clang with the MSVC STL does not, so
the header fails to compile there. Upstream fixed this in 42d8953
("add missing headers"), which also adds a missing include to
sized_unsigned.hpp. That is the only commit between the old pin
(d64ec1d) and the new one, so there are no other changes.
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped dependency update matches the described upstream commit and fixes the missing includes without other code changes.
0 open findings
What changed in this PR
Updates the bundled hid-rp dependency to fix standalone C++20 header compilation.
Changes:
- Bumps
hid-rpfromd64ec1dto42d8953. - Adds required upstream
<bit>and<limits>includes.
| File | Description |
|---|---|
components/hid-rp/detail/hid-rp |
Updates the submodule revision containing the header fixes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
finger563
approved these changes
Oct 11, 2026
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the
components/hid-rp/detail/hid-rpsubmodule fromd64ec1dto42d8953("add missing headers"). That is the only upstream commit between the two. It adds#include <bit>tohid/rdf/short_item.hppand a missing include tosized_unsigned.hpp, and changes nothing else.Motivation and Context
hid/rdf/short_item.hppusesstd::bit_castwithout including<bit>. GCC pulls<bit>in transitively, so the ESP-IDF builds are fine, but clang with the MSVC STL does not, and the header fails withno member named 'bit_cast' in namespace 'std'. We hit this building hid-rp code on a Windows host and worked around it by including<bit>first.How has this been tested?
clang 22.1.8 (
x86_64-pc-windows-msvc, MSVC STL) on Windows 11:-std=c++20and the component's include paths. Atd64ec1d12 of 20 fail; at42d8953all 20 compile.components/hid-rp/testwith the commands in their header comments (-Wall -Wextra -Werror).hid_rp_3dconnexion_host_test,hid_rp_gamepad_host_testandhid_rp_report_map_host_testpass at the new pin.Two things showed up that are not caused by this change (identical at both pins), noted here in case they are useful:
hid-rp-switch-pro.hppusesauto(x)in a concept, which is C++23. GCC accepts it in C++20 mode, clang rejects it, sohid_rp_report_map_host_testandhid_rp_reports_host_testonly compile on clang with-std=c++23.-std=c++23,hid_rp_reports_host_testhitsstatic_assert(num_data_bytes == 9)forPlaystationDualsenseBLESimpleInputReportunder the MSVC ABI.I did not run
idf.py build; the submodule change only adds two includes.Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.