Repository navigation
Fix HTML table generation with lazy loading - #3336
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Resolve Lorem through Faker's existing lazy loader when generating table cells. Exercise the documented API in a fresh process so earlier tests cannot mask the unresolved constant. Assisted-by: Hermes Agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
With
FAKER_LAZY_LOAD=1, callingFaker::HTML.tablein a fresh Ruby process raisesNameErrorforLorem.Faker::HTML.randomcan encounter the same failure when it chooses a table. Eager loading, or using Lorem first, masks the problem.Qualify the table-row generator's remaining reference as
Faker::Lorem, matching the other HTML methods and invoking the existing lazy loader. The regression runs in a fresh process so other tests cannot preload Lorem and hide the failure. This completes a missed reference in #3244 and does not overlap the generators fixed in #3253.Additional information
Verified on Ruby 3.4.11/macOS: the new regression and a separate public-API reproduction fail on the original code and pass with the fix. The complete
bundle exec rakepasses, including RuboCop; the lazy-loading test suite and a built/installed gem also pass. Seeded eager-mode HTML output remains byte-identical. Other Ruby/OS combinations have not been run locally.AI agents performed the investigation, implementation, independent code review, and testing; no human review is claimed.
Checklist