Skip to content

Migrate the testapps to use SPM from Cocoapods - #1923

Merged
a-maurice merged 6 commits into
mainfrom
am-testapp_spm
Sep 24, 2026
Merged

a-maurice merged 6 commits into
mainfrom
am-testapp_spm

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Migrate the testapps to use Swift Package Manager to include the Firebase iOS SDK dependencies, instead of using Cocoapods.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Building the tests locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the iOS and tvOS integration tests from CocoaPods to Swift Package Manager (SPM). The changes include removing Podfiles across all test apps, updating Xcode project configurations to resolve the firebase-ios-sdk package, adjusting build scripts and documentation to reference the .xcodeproj instead of the .xcworkspace, and updating the dependency management script to parse and update SPM versions in project.pbxproj files. The review feedback highlights a few Python best practices, specifically recommending against the use of mutable default arguments and advising that file operations explicitly specify UTF-8 encoding to ensure cross-platform compatibility.

Comment thread scripts/update_android_ios_dependencies.py
Comment thread scripts/update_android_ios_dependencies.py Outdated
Comment thread scripts/update_android_ios_dependencies.py Outdated
@a-maurice a-maurice added skip-release-notes Skip release notes check tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Sep 21, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @a-maurice on commit 935f4a3
Last updated: Thu Sep 24 11:59 PDT 2026
View integration test log & download artifacts

Failures Configs
remote_config [BUILD] [ERROR] [Android] [1/3 os: macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Sep 22, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 22, 2026
@a-maurice a-maurice removed the tests: failed This PR's integration tests failed. label Sep 24, 2026
@a-maurice
a-maurice merged commit 935f4a3 into main Sep 24, 2026
42 of 44 checks passed
@a-maurice
a-maurice deleted the am-testapp_spm branch September 24, 2026 17:30
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Sep 24, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants