Repository navigation
ci(NoTicket): update Node 24 actions and clean up Core credentials - #543
Merged
Merged
Conversation
lorenzhs
changed the title
lorenzhs
marked this pull request as ready for review
October 7, 2026 13:00
|
Contributor
Author
|
core integration tests still work: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/37625183556 |
fstr
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration workflows emit deprecated Node runtime warnings from their setup and commit-status actions. Adopt the merged Node 24 updates from firebolt-db/action-setup-core#4 and firebolt-db/integration-testing-setup#48, including the nightly integration setup use.
Replace the archived Sibz commit-status wrapper with actions/github-script v9, preserving the existing status context, success/failure behavior, commit target, and workflow-run link. All action references remain pinned to full commit hashes.
Replace undeclared staging-secret references with empty SERVICE_ID and SERVICE_SECRET values in both Core HTTP/HTTPS test steps. Core uses FireboltCore auth; the empty placeholders satisfy the shared fixtures and preserve the existing behavior of unpassed secrets resolving to empty strings. This also removes the four workflow lint warnings.
Validation: the changed integration workflows pass actionlint with no exclusions; pre-commit and diff checks passed. The status script passed Node 24 checks for success/failure and PR/regular commit targets. Upstream setup bundles rebuilt on Node 24 without changes. Live integration execution is pending CI.
Note
Medium Risk
CI-only changes, but empty core test credentials and new setup-action pins could change whether integration jobs pass until validated in live runs.
Overview
Updates CI integration workflows to Node 24–compatible action pins:
action-setup-coreon a newermaincommit, andintegration-testing-setupon thenew-identitybranch commit (v2 integration and nightly setup steps).Replaces the archived Sibz/github-status-action with
actions/github-scriptv9, using an inline script that still posts the Integration tests commit status from upstream job results (success/failure, PR head SHA, workflow run link).In core integration tests,
SERVICE_ID/SERVICE_SECRETare set to empty strings instead of staging identity secrets—aligned with core tests that authenticate viaFireboltCoreandCORE_URLonly.Reviewed by Cursor Bugbot for commit 900d24e. Bugbot is set up for automated code reviews on this repo. Configure here.