Repository navigation
qemu_template: add -S flag for snapshot mode - #4310
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The short flag conflicts with QEMU’s existing -S behavior, while raw writable pflash images may have restricted writes.
2 open findings
What changed in this PR
Adds snapshot-mode support to the QEMU wrapper and adjusts pflash format handling.
Changes:
- Adds
-S/-snapshotwrapper options. - Enables snapshots for writable drives and pflash.
- Removes hardcoded qcow2 pflash formats.
| File | Description |
|---|---|
build_library/qemu_template.sh |
Adds snapshot configuration to QEMU drive arguments. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
9674b1f to
77d4f4e
Compare
This change adds the -S flag to Flatcar's qemu wrapper, thoroughly integrating qemu's snapshot mode across all disk devices in the wrapper. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
77d4f4e to
7235073
Compare
Makes sense; I removed that change. |
There was a problem hiding this comment.
🟡 Changes recommended
Passthrough drives remain writable in snapshot mode, and the stated pflash format removal is missing.
3 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
There was a problem hiding this comment.
🟢 Approval recommended
Snapshot behavior is consistently applied to all wrapper-managed writable block devices.
2 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This change fixes a corner case in flatcar#4310 when the new '-S' option introduced in that PR was not provided, but the classic '-- -snapshot' pass-through option is used. Since the PR explicitly sets 'snapshot=off' on all disks individually, and since per-disk options override global options, '-- -snapshot' is effectively ignored. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This change adds the
-Sflag to Flatcar's qemu wrapper, thoroughly integrating qemu's snapshot mode across all disk devices in the wrapper.