Repository navigation
github: Make posting image change reports to a PR non-fatal - #4315
Merged
Merged
Conversation
This is currently failing following the Linux 6.18 bump because the changes are too large for the GitHub API. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow change matches the stated intent without masking build or artifact-upload failures.
0 open findings
What changed in this PR
Makes oversized PR image-change reports non-fatal while retaining uploaded report artifacts.
Changes:
- Allows CI to continue if posting a report comment fails.
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Marks the PR report-posting step as non-fatal. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tormath1
approved these changes
Oct 9, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently failing following the Linux 6.18 bump because the changes are too large for the GitHub API.