Repository navigation
in_tail: document num_threads - #716
Merged
Merged
Conversation
✅ Deploy Preview for fluentd-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Watson1978
force-pushed
the
in-tail-num-threads
branch
from
October 22, 2026 10:04
32bb2fe to
61ffb81
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
in-tail-num-threads
branch
from
October 22, 2026 10:06
61ffb81 to
b4b8755
Compare
ashie
requested changes
Oct 22, 2026
ashie
left a comment
ashie
left a comment
Member
There was a problem hiding this comment.
Overall, this accurately describes the implementation and clearly explains the intended latency benefits without promising higher throughput. I left a few inline suggestions to clarify the compatibility conditions, restart behavior, and limitations of the latency improvement.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
ashie
approved these changes
Oct 23, 2026
ashie
left a comment
ashie
left a comment
Member
There was a problem hiding this comment.
Thanks! All three points have been addressed. The updated documentation looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fluent/fluentd#5529 adds
num_threadstoin_tail, released in v1.20.0. This documents the parameter: what moves to the worker threads and what stays on the event loop, the conditions under which worker parsing is enabled, the bounded queue, the behavior on parse errors and at shutdown, and the fields added toin_monitor_agent.This should be merged after v1.20.0 is released.
🤖 Generated with Claude Code