Repository navigation
Re-enable Zulip tests - #507
Open
chrisbobbe wants to merge 1 commit into
Open
chrisbobbe wants to merge 1 commit into
chrisbobbe wants to merge 1 commit into
Conversation
Our tests were disabled in flutter#478, quite understandably: they were flaking (flutter/flutter#178364, flutter/flutter#179122), and we went two weeks without responding, where registry/template.test asks contacts to respond within about 72 hours. We've since diagnosed and fixed that flake (a test was implicitly depending on the date/time on a real clock): zulip/zulip-flutter#2454 We also fixed another, rarer flake of the same kind, which showed up in a Claude-assisted audit: zulip/zulip-flutter#2455 (The audit also uncovered some cases where the behavior of a file's tests would depend on the order in which the tests ran, and we fixed those too: zulip/zulip-flutter#2457.) So we're proposing re-enablement. The new pin is zulip/zulip-flutter's `main` on 2026-10-08, which includes all three fixes. Greg has left full-time work on Zulip: https://blog.zulip.com/2026/05/15/announcing-zulip-foundation/ I (Chris) am now the mobile-app lead. This commit removes Greg's contact and adds my coworker Rajesh. On GitHub, we're @chrisbobbe and @rajveermalviya.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tests were disabled in #478, quite understandably: they were flaking (flutter/flutter#178364, flutter/flutter#179122), and we went two weeks without responding, where registry/template.test asks contacts to respond within about 72 hours.
We've since diagnosed and fixed that flake (a test was implicitly depending on the date/time on a real clock):
zulip/zulip-flutter#2454
We also fixed another, rarer flake of the same kind, which showed up in a Claude-assisted audit:
zulip/zulip-flutter#2455
(The audit also uncovered some cases where the behavior of a file's tests would depend on the order in which the tests ran, and we fixed those too: zulip/zulip-flutter#2457.)
So we're proposing re-enablement. The new pin is zulip/zulip-flutter's
mainon 2026-10-08, which includes all three fixes.Greg has left full-time work on Zulip:
https://blog.zulip.com/2026/05/15/announcing-zulip-foundation/
I (Chris) am now the mobile-app lead. This commit removes Greg's contact and adds my coworker Rajesh. On GitHub, we're @chrisbobbe and @rajveermalviya.
Important
This repository is a testing suite that contains references to tests (in the
registrydirectory) that are run with every commit to Flutterto verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is not automatically run in the
Flutter CI tree.
After merging this PR, you must send another PR to flutter/flutter updating
dev/customer_testing/tests.versionin that repo with the latest git commit SHA of the flutter/test repo.See flutter/flutter#162048 for details.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.