Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
sdk-develop-docs
s1gr1d
marked this pull request as ready for review
October 20, 2026 15:11
Contributor
|
Rollouts skipped this pull request: Documentation-only change in an application repo (MDX in develop-docs) that does not ship to a deployed site. Mention |
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 20, 2026
Without a type, the link from a pageload to the server request whose trace context arrived too late shows up in Sentry with no meaning. The type is documented in getsentry/sentry-docs#20112.
nicohrubec
reviewed
Oct 20, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
looks good to me but should we add this to conventions first?
Lms24
approved these changes
Oct 21, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
+1 for adding this to conventions
Merged
2 tasks done
Member
Author
|
Merged in conventions: getsentry/sentry-conventions#738 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a link type for a page load span that could not continue the trace of the server request that rendered its document.
With streamed HTML, the trace context can arrive after the page load span started. For example, a prerendered shell is served first and the dynamic part, which carries the
sentry-tracemeta tag, streams in later. A started span cannot move to another trace, so the SDK links it to the server request instead. Without a type, the link shows up in Sentry with no meaning attached. The JavaScript SDK sets it in getsentry/sentry-javascript#25142.Refs getsentry/sentry-javascript#25142
Conventions PR: getsentry/sentry-conventions#738
IS YOUR CHANGE URGENT?