Skip to content

ci: Keep Namespace cache volumes complete and cache the pnpm binary - #25569

Open
JPeer264 wants to merge 2 commits into
developfrom
jp/namespace-cache-tags
Open

JPeer264 wants to merge 2 commits into
developfrom
jp/namespace-cache-tags

Conversation

@JPeer264

Copy link
Copy Markdown
Member

This gives the E2E jobs their own Namespace cache tag and removes the tag from jobs that do not use a cache. A new mount-pnpm-store action mounts the pnpm store and the npm cache before install-pnpm, so pnpm itself also comes from the cache volume.

Why

Namespace keeps the volume of the last job that exits cleanly. E2E jobs and jobs without cache use often finished last, so Build got no node_modules in about 8 of 10 runs. pnpm self-update also downloaded pnpm in every job, which took up to 130s.

Cache decisions

cache: pnpm runs pnpm, so it cannot come before install-pnpm. Until Namespace changes this, mount-pnpm-store sets PNPM_CONFIG_STORE_DIR itself.

Namespace keeps the cache volume of every job that exits cleanly, and the
last write wins. E2E jobs and jobs without cache use had the same tag as
the dependency volume, so they often committed an empty or E2E-only
volume, and the next Build installed all dependencies again. E2E jobs
now use their own tag, and jobs without cache use have no tag.

`pnpm/action-setup` downloads pnpm with `pnpm self-update` in every job.
The new `mount-pnpm-store` action mounts the pnpm store and the npm
cache before `install-pnpm`, so both downloads come from the cache
volume. The `pnpm` mode of nscloud-cache-action runs pnpm, so the action
sets `PNPM_CONFIG_STORE_DIR` itself until the mode works without pnpm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JPeer264
JPeer264 marked this pull request as ready for review October 20, 2026 16:37
@JPeer264 JPeer264 self-assigned this Oct 20, 2026
@JPeer264
JPeer264 requested a review from andreiborza October 20, 2026 16:38

@andreiborza andreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja passt

@JPeer264
JPeer264 enabled auto-merge (squash) October 20, 2026 16:39
@JPeer264
JPeer264 disabled auto-merge October 20, 2026 17:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants