test(quart): Fix flake caused by flushing spans on segment end - #7240
Merged
Conversation
ericapisani
approved these changes
Aug 24, 2026
Contributor
Codecov Results 📊✅ 117463 passed | ⏭️ 6732 skipped | Total: 124195 | Pass Rate: 94.58% | Execution Time: 420m 19s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2488 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.22% —%
==========================================
Files 193 193 —
Lines 25433 25433 —
Branches 9346 9346 —
==========================================
+ Hits 22945 22945 —
- Misses 2488 2488 —
- Partials 1437 1437 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The background flush on segment end is asynchronous, and spans from different traces are not guaranteed to be ordered.
The error is
Analogous to 4ada8f1
Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)