Skip to content

test(quart): Fix flake caused by flushing spans on segment end - #7240

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/quart/flaky-test
Aug 24, 2026
Merged

test(quart): Fix flake caused by flushing spans on segment end#7240
alexander-alderman-webb merged 1 commit into
masterfrom
webb/quart/flaky-test

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

The background flush on segment end is asynchronous, and spans from different traces are not guaranteed to be ordered.

The error is

_______________ test_span_streaming_quart_auth_user_id[42-True] ________________
tests/integrations/quart/test_quart.py:1118: in test_span_streaming_quart_auth_user_id
    assert segment["attributes"]["user.id"] == user_id
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   KeyError: 'user.id'

Analogous to 4ada8f1

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner August 24, 2026 14:16
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

117463 passed | ⏭️ 6732 skipped | Total: 124195 | Pass Rate: 94.58% | Execution Time: 420m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +2743
Passed Tests 📈 +2745
Failed Tests 📉 -2
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2488 uncovered lines.
✅ Project coverage is 90.22%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.22%    90.22%        —%
==========================================
  Files          193       193         —
  Lines        25433     25433         —
  Branches      9346      9346         —
==========================================
+ Hits         22945     22945         —
- Misses        2488      2488         —
- Partials      1437      1437         —

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 078741f into master Aug 24, 2026
144 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/quart/flaky-test branch August 24, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants