Repository navigation
fix(github): pass non-nil upload options when uploading release assets - #180
Merged
andrew merged 1 commit intoOct 19, 2026
Merged
Conversation
UploadReleaseAsset dereferences opts.MediaType, so the nil options value panicked inside go-github. Name the asset after the uploaded file, like the gitea service does. Fixes git-pkgs#178. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
andrew
approved these changes
Oct 19, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
The non-nil upload options fix the reported panic and supply the asset filename. The HTTP regression test covers the upload path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178.
Summary
Github: can't upload assets to release due to nil pointer dereference
Checks