Repository navigation
Apply --head filter client-side for Gitea/Forgejo pr list - #181
Merged
andrew merged 1 commit intoOct 19, 2026
Merged
Conversation
The Gitea/Forgejo list-pull-requests API (and the gitea SDK) expose no head filter, so --head was accepted by the CLI and passed into ListPROpts but silently dropped by the backend, listing every PR. Filter client-side with GitHub-compatible semantics: an unqualified --head matches the head branch name; a qualified owner:branch value also requires the head repository owner to match (a head in the same repository matches when the qualifier names the base repo owner). The result limit is enforced after filtering. Fixes git-pkgs#111. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
andrew
approved these changes
Oct 19, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
The head filter handles branch names and qualified fork owners correctly, with the result limit applied after filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111.
The Gitea/Forgejo list-pull-requests API (and the gitea SDK) expose no
head filter, so --head was accepted by the CLI and passed into
ListPROpts but silently dropped by the backend, listing every PR.
Filter client-side with GitHub-compatible semantics: an unqualified
--head matches the head branch name; a qualified owner:branch value
also requires the head repository owner to match (a head in the same
repository matches when the qualifier names the base repo owner).
The result limit is enforced after filtering.
Evidence
TestGiteaListPRsAppliesHeadFilteringitea/prs_test.gocovering unqualified and qualified head matching.
Honest limits
were not run locally; CI is the test backstop for build, vet, and tests.