Normalize interrupted shell replay results - #2370
Merged
Merged
Conversation
Treat runtime shell-context reconfiguration as the same semantic interruption already represented by abort cassettes, while retaining strict matching for unrelated tool failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes equivalent interrupted shell results so shared SDK replay cassettes remain stable across runtime timing differences.
Changes:
- Extends interrupted-tool result normalization for shell reconfiguration.
- Adds capture, replay, and strict mismatch coverage.
Show a summary per file
| File | Description |
|---|---|
test/harness/replayingCapiProxy.ts |
Canonicalizes the shell interruption result. |
test/harness/replayingCapiProxy.test.ts |
Verifies capture and replay normalization behavior. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<shell context is being reconfigured; retry the command>result to the replay harness's existing canonical interrupted-tool resultsession/should_abort_a_session.yamlThis fixes the abort-session replay failure observed in copilot-agent-runtime#16636, specifically workflow run 32478858178 / CAPI C# job 96769866111. The test remains responsible for verifying that abort leaves the session alive and usable; it no longer depends on which semantically equivalent cancellation string wins a timing race.
Validation
Should_Abort_A_Sessionshould abort a sessionTestSessionE2E/should_abort_a_sessionsession::should_abort_a_sessionCopilotSessionTest#testShouldAbortSessionPython uses the same shared replay harness and cassette; it was not run locally because this host has no Python interpreter.