Skip to content

Expose sandbox bypass in Rust API - #2372

Open
ellismg wants to merge 1 commit into
mainfrom
ellismg-expose-sandbox-bypass
Open

Expose sandbox bypass in Rust API#2372
ellismg wants to merge 1 commit into
mainfrom
ellismg-expose-sandbox-bypass

Conversation

@ellismg

@ellismg ellismg commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enrich the Rust codegen input with the runtime's optional SandboxConfig.allowBypass host capability until the pinned CLI schema includes it
  • regenerate SandboxConfig with idiomatic allow_bypass: Option<bool> and camelCase serde output
  • cover serialization of Some(true) and omission of None

Paired with github/github-app#12088.

Validation

  • cargo test --test api_types_test sandbox_allow_bypass_serializes_as_optional_camel_case -- --exact
  • cargo +nightly-2026-04-14 fmt --check
  • cargo clippy --all-features --all-targets -- -D warnings
  • cargo test --all-features (608 passed; 10 concurrent E2E proxy startup timeouts; sampled failures passed serially)

Teach the Rust code generator about the runtime's allowBypass host capability until the pinned CLI schema includes it, then verify camelCase serialization and omission when unset.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 22, 2026 04:23
@ellismg
ellismg requested a review from a team as a code owner August 22, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Exposes the runtime’s optional sandbox-bypass capability through the Rust SDK.

Changes:

  • Augments the API schema during Rust code generation.
  • Regenerates SandboxConfig with optional camelCase serialization.
  • Tests enabled and omitted serialization behavior.
Show a summary per file
File Description
scripts/codegen/utils.ts Adds the temporary schema augmentation.
scripts/codegen/rust.ts Applies augmentation during Rust generation.
rust/src/generated/api_types.rs Adds allow_bypass to SandboxConfig.
rust/tests/api_types_test.rs Verifies serialization and omission.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 3/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants