fix(python): serialize native values in tool results - #2374
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2203
Summary
Complete the plain-container serialization case intentionally left out of #2225. Python tool handlers can now return dictionaries containing common native values without those successful results being converted into opaque tool failures.
Fix
Extend the existing json.dumps fallback with the same JSON-safe representations used for Pydantic tool results:
Unsupported objects continue to raise the existing clear serialization error.
Tests
The regression test failed on current main with:
Passing validation:
No Copilot session, model, paid API, or external service is required for the regression test. Authenticated runtime E2E tests were not run locally.