Repository navigation
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix codex standalone search rejection due to body fields
Accept Codex standalone search input and output limits
Oct 9, 2026
lpcox
marked this pull request as ready for review
October 9, 2026 15:55
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused compatibility change preserves existing security boundaries and includes adequate regression coverage.
0 open findings
What changed in this PR
Adds compatibility for Codex standalone hosted-search requests, resolving #9744 while retaining existing policy enforcement.
Changes:
- Accepts and validates
max_output_tokensand conversationinput. - Preserves these fields while applying domain filters.
- Adds regression coverage for both standalone endpoints and invalid values.
| File | Description |
|---|---|
containers/api-proxy/codex-hosted-web.js |
Allows and validates the new standalone request fields. |
containers/api-proxy/codex-hosted-web.test.js |
Covers preservation, validation, and endpoint routing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
✅ Copilot review passed with no inline comments. @copilot Add the |
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex 0.159.3 standalone search requests include
max_output_tokensand often conversationinput. The proxy rejects both as unknown fields, preventing search even when hosted-web policy permits it.Request compatibility
max_output_tokensas a non-negative integer.inputas a string or array; preserve both fields when applying policy filters.Policy boundaries
maxUsesrejection.reasoningand additional command types unsupported.Regression coverage