Reuse shared workflow types for Copilot setup scaffolding by Copilot · Pull Request #54804 · github/gh-aw

Copilot · 2026-08-22T13:22:44Z

Copilot setup scaffolding maintained a separate GitHub Actions workflow, job, and step model in pkg/cli. This consolidates the model under pkg/workflow and reuses the primary WorkflowStep type.

Shared workflow-file model
- Added workflow.WorkflowFile and workflow.WorkflowFileJob for YAML workflow-file serialization.
- Kept flexible on, runs-on, and permissions fields required when reading existing workflows.
Removed CLI-local duplicates
- Deleted CopilotWorkflowStep, WorkflowJob, and Workflow from copilot_setup.go.
- Updated Copilot setup YAML fixtures and round-trip tests to use shared types.

workflow.WorkflowFile{
    Jobs: map[string]workflow.WorkflowFileJob{
        "copilot-setup-steps": {
            Steps: []workflow.WorkflowStep{
                {Name: "Install gh-aw extension", Run: "…"},
            },
        },
    },
}

Fixes [deep-report] Replace copilot_setup.go's duplicate GHA workflow model with pkg/workflow types #54529

pr-sous-chef run https://github.com/github/gh-aw/actions/runs/32578995676> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.2 AIC · ⌖ 8.25 AIC · ⊞ 9.5K · ◷

_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-08-22T13:52:29Z

          "$ref": "#/definitions/permissions-level"
        },
-        "drives": {
-          "$ref": "#/definitions/permissions-level"


@copilot revert change and merge main

Restored the drives schema permission and merged main in 320f1e7.

Reverted the stray local edit to pkg/workflow/schemas/github-workflow.json — the branch is already merged with main (370f5c2) and the file now matches main's drives position exactly.

…eplace-duplicate-gha-workflow-model Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-22T14:13:50Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-22T14:13:54Z

✅ Ponytail Reviewer completed successfully!

Ponytail review: PR is a pure deduplication refactor (removes duplicate CopilotWorkflowStep/WorkflowJob/Workflow types, reuses shared workflow.WorkflowFile/WorkflowFileJob/WorkflowStep). Net deletion of code, no speculative abstractions or reinvented logic found. Lean already. Ship.

Generated by Ponytail Reviewer for #54804

github-actions · 2026-08-22T14:13:57Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-22T14:13:57Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-22T14:13:59Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (46 additions detected, threshold is 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

…rkflow-model

github-actions · 2026-08-22T14:14:27Z

🛠️ Agentic Maintenance updated this pull request branch.

View workflow run

Copilot

Pull request overview

Consolidates Copilot setup workflow fixtures around shared pkg/workflow types.

Changes:

Adds shared workflow-file and job models.
Replaces CLI-local step models in tests.
Regenerates command routing with an unrelated smoke-drive route.

Show a summary per file

File	Description
`pkg/workflow/workflow_file.go`	Adds shared YAML models.
`pkg/cli/copilot_setup.go`	Removes local duplicate types.
`pkg/cli/copilot_setup_test.go`	Migrates tests to shared types.
`.github/workflows/agentic_commands.yml`	Adds `smoke-drive` routing.

Review details

Files reviewed: 4/4 changed files
Comments generated: 3
Review effort level: Balanced

+type WorkflowFile struct {
+	Name string                     `yaml:"name,omitempty"`
+	On   any                        `yaml:"on,omitempty"`
+	Jobs map[string]WorkflowFileJob `yaml:"jobs,omitempty"`


 #     /smoke-crush -> smoke-crush [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes
 #     /smoke-cursor -> smoke-cursor [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket
 #     /smoke-deepseek-harness -> smoke-deepseek-harness [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes
+#     /smoke-drive -> smoke-drive [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket


+// WorkflowFileJob represents a GitHub Actions workflow job in a workflow file.
+type WorkflowFileJob struct {
+	RunsOn      any            `yaml:"runs-on,omitempty"`
+	Permissions map[string]any `yaml:"permissions,omitempty"`


github-actions · 2026-08-22T14:17:57Z

Comment Memory

reviewed_at: 2026-08-22T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues in changed lines
  - shared workflow model reuse looks behaviorally equivalent
files_reviewed:
  - .github/workflows/agentic_commands.yml
  - pkg/cli/copilot_setup.go
  - pkg/cli/copilot_setup_test.go
  - pkg/workflow/workflow_file.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 18.7 AIC · ⌖ 6.75 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

github-actions

No actionable changed-line issues stood out here. The new shared workflow-file structs match the old copilot setup YAML shape, keep the flexible on/runs-on/permissions typing needed for round-tripping existing workflow files, and the test updates cover the moved types without changing behavior.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 18.7 AIC · ⌖ 6.75 AIC · ⊞ 7K
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /codebase-design — one suggestion, otherwise clean consolidation work.

📋 Summary

What this PR does well

✅ Clean elimination of duplicate types (CopilotWorkflowStep, WorkflowJob, Workflow) in favour of shared pkg/workflow equivalents — reduces the maintenance surface and the risk of the two models diverging.
✅ Narrowing Env from map[string]any → map[string]string is the right semantic tightening; the test rename from TestCopilotWorkflowStepStructure → TestWorkflowStepYAMLStructure and TestWorkflowStructMarshaling → TestWorkflowFileMarshaling improves clarity.
✅ New file pkg/workflow/workflow_file.go is minimal and well-placed.

One suggestion

WorkflowFileJob.Permissions is map[string]any while GitHub Actions permission values are always strings. The PR already applied this tightening to Env — applying it to Permissions too would be consistent. See inline comment.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 33.5 AIC · ⌖ 9.79 AIC · ⊞ 7.6K
_{Comment /matt to run again}

github-actions · 2026-08-22T14:18:56Z

+type WorkflowFileJob struct {
+	RunsOn      any            `yaml:"runs-on,omitempty"`
+	Permissions map[string]any `yaml:"permissions,omitempty"`
+	Steps       []WorkflowStep `yaml:"steps,omitempty"`


[/codebase-design] Permissions is typed map[string]any, but GitHub Actions permission values are always strings ("read", "write", "none"). This PR already narrowed Env from map[string]any → map[string]string on WorkflowStep for the same reason — Permissions deserves the same treatment for consistency.

💡 Suggested change

// Before Permissions map[string]any `yaml:"permissions,omitempty"` // After Permissions map[string]string `yaml:"permissions,omitempty"`

This keeps the type vocabulary consistent and catches bad permission values at compile time rather than at runtime.

@copilot please address this.

Replaced Permissions map[string]any with a new WorkflowFilePermissions union type that supports both the scope-map form (contents: read) as map[string]string and the shorthand scalar form (read-all/write-all/none), since a plain map[string]string alone can't represent the scalar permissions case raised in the other thread.

github-actions

Clean refactor — no blocking issues found.

The PR removes three locally-defined types (CopilotWorkflowStep, WorkflowJob, Workflow) from copilot_setup.go and replaces them with the shared workflow.WorkflowStep, workflow.WorkflowFileJob, and workflow.WorkflowFile. This reduces duplication and ensures the copilot-setup scaffolding stays in sync with the rest of the compiler's type system.

Notable improvement: Env map[string]any → Env map[string]string. GitHub Actions environment values must be strings, so the tighter type is strictly correct and prevents accidental non-string values.

All test references are updated consistently. LGTM.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 38.9 AIC · ⌖ 9 AIC · ⊞ 6.2K

…rkflow-model

gh-aw-bot · 2026-08-22T14:38:22Z

@copilot this PR looks close, but there is still one maintainer-facing follow-up to finish.

Please review the latest comments and any unresolved review feedback, refresh the branch if needed, and run the pr-finisher skill.
Leave a concise maintainer handoff that lists the exact validations rerun and whether any human follow-up remains.

Run: https://github.com/github/gh-aw/actions/runs/32578995676

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.2 AIC · ⌖ 8.25 AIC · ⊞ 9.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-22T14:38:27Z

@gh-aw-bot Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 354953ed-c7ce-404f-a1f9-777f96229473

Sorry for the inconvenience!

…cope Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-22T14:53:06Z

@copilot this PR looks close, but there is still one maintainer-facing follow-up to finish.

Please review the latest comments and any unresolved review feedback, refresh the branch if needed, and r...

pr-finisher pass complete:

Reviews: addressed and replied on the drives-schema thread (reverted stray edit; already merged with main) and the permissions-type thread (added WorkflowFilePermissions union type supporting both scalar shorthand and scope-map forms). The /smoke-drive route flagged in an older review is pre-existing on main, not drift from this PR — no change made.
Checks (local): go build ./..., targeted pkg/cli/pkg/workflow tests, make fmt, make lint, and make test-unit all pass.
Checks (CI): stale after this push — needs a maintainer re-trigger.
Mergeable: no conflicts with main (already merged in as of 370f5c2).

Still needed: a maintainer re-trigger of CI and final human review/approval before merge.

Initial plan

3c2eb91

Copilot AI assigned Copilot and pelikhan Aug 22, 2026

Copilot started work on behalf of pelikhan August 22, 2026 13:23 View session

Copilot AI linked an issue Aug 22, 2026 that may be closed by this pull request

[deep-report] Replace copilot_setup.go's duplicate GHA workflow model with pkg/workflow types #54529

Closed

Copilot AI and others added 2 commits August 22, 2026 13:27

Plan workflow model consolidation

29548d7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Reuse workflow step model for Copilot setup

551c9f8

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Replace duplicate GHA workflow model with pkg/workflow types~~ Reuse shared workflow types for Copilot setup scaffolding Aug 22, 2026

Copilot finished work on behalf of pelikhan August 22, 2026 13:39

Copilot AI requested a review from pelikhan August 22, 2026 13:39

pelikhan reviewed Aug 22, 2026

View reviewed changes

Copilot started work on behalf of pelikhan August 22, 2026 13:52 View session

Copilot AI and others added 2 commits August 22, 2026 14:00

Merge remote-tracking branch 'origin/main' into copilot/deep-report-r…

bde2a4c

…eplace-duplicate-gha-workflow-model Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Restore drives permission schema

320f1e7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan marked this pull request as ready for review August 22, 2026 14:09

Copilot AI balanced review requested due to automatic review settings August 22, 2026 14:09

Copilot finished work on behalf of pelikhan August 22, 2026 14:09

Copilot AI requested a review from pelikhan August 22, 2026 14:09

Copilot started reviewing on behalf of pelikhan August 22, 2026 14:10 View session

Merge branch 'main' into copilot/deep-report-replace-duplicate-gha-wo…

99e07c0

…rkflow-model

Copilot AI reviewed Aug 22, 2026

View reviewed changes

github-actions Bot reviewed Aug 22, 2026

View reviewed changes

github-actions Bot approved these changes Aug 22, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 22, 2026

[pr-sous-chef] PR Sous Chef run report #54661

Open

Merge branch 'main' into copilot/deep-report-replace-duplicate-gha-wo…

370f5c2

…rkflow-model

Copilot started work on behalf of gh-aw-bot August 22, 2026 14:39 View session

Add union-typed permissions to WorkflowFileJob and document fixture s…

909f060

…cope Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 22, 2026 14:53

Copilot AI requested a review from gh-aw-bot August 22, 2026 14:53

pelikhan merged commit 15041fe into main Aug 22, 2026
31 checks passed

pelikhan deleted the copilot/deep-report-replace-duplicate-gha-workflow-model branch August 22, 2026 15:10

Uh oh!

Conversation

Copilot AI commented Aug 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Aug 22, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

What this PR does well

One suggestion

Uh oh!

github-actions Bot Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 22, 2026

Uh oh!

Copilot AI commented Aug 22, 2026

Uh oh!

Copilot AI commented Aug 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 22, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading

github-actions Bot commented Aug 22, 2026 •

edited

Loading