Repository navigation
Fix repository recognition for SSH mapped configurations - #554
Merged
skarim merged 2 commits intoOct 9, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The valid dependency release contains the intended SSH alias fix, and the module files are consistent.
0 open findings
What changed in this PR
Updates go-gh to fix repository detection for remotes using SSH host aliases.
Changes:
- Bumps
go-ghfrom v2.16.1 to v2.16.2. - Updates module checksums accordingly.
| File | Description |
|---|---|
go.mod |
Updates the direct go-gh dependency. |
go.sum |
Records matching v2.16.2 checksums. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
williammartin
marked this pull request as draft
October 9, 2026 10:49
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
williammartin
force-pushed
the
williammartin-vhs-demo-ssh-alias
branch
from
October 9, 2026 11:42
02594ae to
e22c782
Compare
williammartin
marked this pull request as ready for review
October 9, 2026 11:42
ktravers
approved these changes
Oct 9, 2026
ktravers
left a comment
Contributor
There was a problem hiding this comment.
Appreciate the test coverage, looks great 🚀
skarim
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #45 and Fixes #337
Description
gh stack submitfails when theoriginremote uses a custom SSH host alias. For example,git@github.com-work:org/repowhere~/.ssh/configmapsgithub.com-worktogithub.com.gh-stackusesrepository.Current()fromgo-ghto work out which repo it is in. That function does expand SSH aliases withssh -G. However, it then filtered remotes on the host from before the expansion. Sogithub.com-worknever matched a known host, and every command needing a GitHub client failed with:This was fixed in cli/go-gh#274 and released in
go-ghv2.16.2. This PR bumps the dependency.How did you test this change?
I built two binaries from the same commit. The only difference was the
go-ghversion.I then ran both against a private repo with an
originofgit@github.com-work:williammartin/gh-stack-ssh-alias-demo.git. Each run used an isolated SSH config wheregithub.com-workresolved togithub.com.The two runs used the same terminal, commands, and repo state. Each one had a two-branch stack (
layer-1andlayer-2) on top ofmain. I rangh stack submit --autoin each.Before (
go-ghv2.16.1), I saw the error above:After (
go-ghat the commit tagged v2.16.2), I saw two draft PRs and a stack created:The after recording shows the replace
=> v2.16.2-0.20261009094949-aadf36735579because I recorded it before the tag existed. The v2.16.2 tag points at that same commit,aadf367.Authorship and follow-up
Who wrote this:
Who answers review comments: