Repository navigation
fix: prevent nil pointer panic in parseOperator (fixes #158) - #163
Closed
AruneshDwivedi wants to merge 1 commit into
Closed
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Fixes issue github#158: panic: nil-pointer dereference when parsing a dangling open parenthesis The peek() function can return nil when there are no more tokens. Accessing token.role on a nil pointer causes a panic. Added nil check before accessing token fields.
Collaborator
|
Thank you for your contribution. This work was superseded by #168. If you feel that PR doesn't address all the potential cases, please add an issue or another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #158: panic: nil-pointer dereference when parsing a dangling open parenthesis
The parseOperator function called t.peek() which can return nil when there are no more
tokens to process. Without a nil check, accessing token.role caused a panic.
Added nil check before accessing token.role in parseOperator to prevent panic on malformed
input with dangling parentheses or unexpected EOF.
This fix ensures that parsing errors are returned gracefully rather than causing a panic.