Skip to content

feat: add maintainer-triggered PR description assessment - #4902

Open
KSchlobohm wants to merge 1 commit into
github:mainfrom
KSchlobohm:kschlobohm-oct-9-upstream-assessment
Open

KSchlobohm wants to merge 1 commit into
github:mainfrom
KSchlobohm:kschlobohm-oct-9-upstream-assessment

Conversation

@KSchlobohm

@KSchlobohm KSchlobohm commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds an optional workflow that collaborators with write access or higher trigger with the pr-assess label. It compares the PR description with the code changes, flags material omissions or contradictions, and posts a concise assessment with an outcome label to help reviewers spot gaps.

Testing

I tested this workflow on my fork. Automated checks passed (137 tests, 16 skips), and live scenarios covered accurate descriptions, missing behavior, contradictory claims, reassessment, and labels applied to issues or closed PRs. I also tested three reproduced upstream PRs and reviewed the comments for accuracy and respectful wording; one result involved a reviewer judgment difference.

Automated check: .\.venv\Scripts\python.exe -m pytest tests\test_github_workflows.py -q — 137 passed, 16 skipped.

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project (if applicable)

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (fill in the disclosure below)

AI disclosure: Prepared and created with GitHub Copilot (GPT-6.1 Sol) under human supervision.

Port the complete pr-assess workflow with concise reviewer-facing comments,
bounded outcome-label updates, focused tests, and usage guidance.

Keep the reviewed gh-aw v0.89.21 runtime pin isolated from existing workflows.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9ee0ab16-f074-4303-82b9-d11bfad16175
Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Authorization exceeds the stated maintainer scope, required labels are not provisioned, and the AI disclosure is incomplete.

3 open findings
What changed in this PR

Adds a maintainer-triggered workflow that evaluates PR description alignment and reports bounded comments and outcome labels.

Changes:

  • Adds the pr-assess agentic workflow and generated lock file.
  • Adds focused workflow configuration and prompt-contract tests.
  • Documents usage and pins the isolated gh-aw runtime dependency.
File Description
.github/​workflows/​pr-assess.md Defines assessment behavior and safeguards.
.github/​workflows/​pr-assess.lock.yml Provides the compiled GitHub Actions workflow.
.github/​aw/​actions-lock.json Pins gh-aw setup v0.89.21.
tests/​test_github_workflows.py Tests triggers, permissions, outputs, and reporting.
docs/​guides/​agentic-sdlc.md Documents maintainer usage and outcomes.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/pr-assess.md
Comment thread .github/workflows/pr-assess.md
Comment thread .github/workflows/pr-assess.md
@KSchlobohm
KSchlobohm requested a balanced review from Copilot October 9, 2026 19:46
@KSchlobohm
KSchlobohm marked this pull request as ready for review October 9, 2026 19:47
@KSchlobohm
KSchlobohm requested a review from mnriem as a code owner October 9, 2026 19:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Separate label removal and addition can leave incorrect verdict state after partial failures.

3 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment on lines +209 to +212
Applying the outcome label is your responsibility, not a recommendation for a
maintainer. Use `remove_labels` to remove any existing outcome labels other than
the selected verdict (up to two labels), then `add_labels` with exactly one
**plain string**:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants