Repository navigation
feat(app): set up a GitHub project's checkout on this machine before creating channels - #205
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204. Part of #15 (follows #157); dogfooding gap from #5.
On Nate16, ace2 is checked out only on natembp. The project appeared as
ace2 · natembp, and none of its channel creation entry points worked. GitHub projects now show their ordinary name everywhere. Folders without a GitHub remote on another host keep the host label.If a GitHub project has no checkout on this machine, Set up on this Mac opens a setup dialog. So do New channel / + (sidebar, All Projects, dashboard) and GitHub Open in a channel. The dialog has an editable destination (default
~/code/<repo>), and nothing is cloned until you confirm it. The host runs a new local-onlyproject-clone, which does a plaingit cloneof the validatedhttps://github.com/<owner>/<repo>.gitand registers the checkout throughproject-open.gh repo cloneisn't used. Its authenticated GraphQL lookup is what organization SAML SSO refused on Nate16, even though ace2 is public. Private repositories use the host's existing Git credentials.Validation:
bun types,bun run ci, and the React Doctor diff scan pass. The only warning is theAppcomplexity one that was already there.Real smoke through a source
ace servegateway with a temporaryHOME/ACE_HOME, no Git config, and noGH_TOKEN:~/code/ace2cloned public ace2 anonymously and registered asgithubnext/ace2.GitHubNext/ACE2opened the existing checkout.createmade a channel listed with that repo and root.Native, after installing signed Canary 0.0.20 (chore(desktop): prepare canary 0.0.20 #206, build-only run 37650079277, DMG SHA-256
04fe5f0a…1840matched, Gatekeeper accepted) on natembp and Nate16:~/code/ace2. It was edited to/Users/natebutler/code/ace2, and Clone and start channel cloned and created a channel within about 12 seconds, with no SSO prompt or error.a24ec4567772d9e0, renamed in the native UI tonate16-ace2-test) appears with natembp's channels under plain ace2.nate16-1, not hosted, repogithubnext/ace2, and project IDgithub:githubnext/ace2. Its project and root are/Users/natebutler/Code/ace2: macOS resolved the typed lowercasecodeto the existingCodefolder, so only an exact-string path assertion differed.Built in Ace
Implementation, checks, the smoke test, the issue, and this PR were done in an Ace channel. Outside Ace: