Skip to content

Route Planner visual authoring through Jev - #415

Merged
MaggieAppleton merged 3 commits into
mainfrom
maggie/planner-visual-authoring
Oct 9, 2026
Merged

MaggieAppleton merged 3 commits into
mainfrom
maggie/planner-visual-authoring

Conversation

@MaggieAppleton

@MaggieAppleton MaggieAppleton commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Jev visual routing update

  • Add an opt-in Planner path (PLANNER_VISUALS=on) for explicit member requests of at most 1,000 characters under copilot-sdk or pi. It sends one explanatory passage to Jev for three small decisions: can it be visualized, would that aid comprehension, and which of Chopin’s 42 SeeCode types, table, or none fits. Accepted-comment turns, longer requests, background jobs, and Atomic retain their ordinary authoring path.
  • Bind Jev’s route to the member turn, document revision, passage, and placement. edit_plan accepts only the assessed paragraph plus its selected diagram or table; human edits and Stop invalidate pending routes.
  • Keep the existing Planner prompt and tool set unchanged when the flag is off. Routed editing currently supports one top-level paragraph per write, with headings in separate edits. Lists and nested MDX prose are explicitly unsupported in this prototype.

Visual routing flow

Jev assessment, route receipt, and validated Planner document edit

Landing review · 9 October 2026

  • Rebuilt the branch as one linear feature commit on current main, preserving all 48 feature files byte for byte before review fixes. The complete reconstruction diff from the old head exactly matched incoming main changes; no previously merged feature commits were replayed.
  • Fixed an opt-in regression found during review: accepted-comment turns lacked the member request required by routing, and long member messages exceeded its request bound. One shared eligibility gate now keeps those turns on their existing prompt, tools, and edit path. Atomic retains its ordinary path because its workflow sessions can survive across turns. A fake-harness regression covers all three harnesses and short, long, and accepted-comment turns; it failed before the fix and passed after it.
  • Current head 5a13eda4 is a single linear commit on main at 9623e25d. Local verification passed: bun test (4,326 passed, four environment-dependent skips, zero failures), bun run ci, bun run types, the web build, and 51 exact-case documentation links. GitHub runs the PostgreSQL, browser, and container checks on this head in CI run 37969587305. No assertions were loosened.
  • Existing live evidence below remains limited to its recorded commits. This landing review made no hosted Planner or Jev calls and did not rerun the live acceptance cohort.

New verification

  • A five-passage Jev classification probe returned possible for 5/5 passages and helpful for 4/5; it selected a flowchart, dependency diagram, table, and one none route. This probe did not run a live Planner authoring turn.
  • Fake-Jev tool tests cover route binding, changed passage/type rejection, in-flight human edits, Stop, and the no-network-under-document-lock boundary. A browser test seeded MDX from the memory-backed tool fixture into a separate database-backed room, then saved an edit and reopened it. This does not exercise a same-room live Planner turn.
  • A separate frozen R1/E1/D1 same-room acceptance runner caps Jev at three dispatches per case and nine overall, stops on an unexpected ask or provider failure, and records the routed Planner instructions and tool set. Its no-call preflight and six focused tests passed. The one authorized live batch stopped in R1: Jev returned possible 0.90, helpful 0.77, and flowchart (confidence 0.77). Planner attempted five diagram edits, all rejected as invalid-visual; an offline renderer check found a 43-character node label over the 40-character limit. A fourth assessment was refused before HTTP dispatch. Planner saved prose and finished its Chat turn, but the runner stopped before a fresh browser reopen. E1 and D1 did not run. This is partial failure evidence, not a live diagram acceptance pass. The batch used one hosted Planner turn and three successful Jev calls.
  • The local repair on b4047aeb returns bounded field and constraint diagnostics from edit_plan. An unavailable Jev assessment now returns ok: false without minting or replacing a write route; a genuine Jev prose decision still permits prose. Focused fake-provider tests cover repair on the same route, initial provider failure, and a rejected diagram followed by failed reassessment. The repair itself made no hosted Planner or Jev calls.
  • A separately released, unchanged-input R1-only live run on b4047aeb completed in one Planner turn and three Jev calls. Jev answered possible 0.90, helpful 0.78, and flowchart (confidence 0.62). The first diagram edit received a precise 40-character label error; Planner shortened that label and saved the eight-node, nine-edge flowchart with the same route and no new assessment. Saved MDX matched a fresh reopen byte for byte, and the browser rendered one SVG without errors. The graph preserves the RFC's creation, polling, Pending, Ready, and completion transitions. Its right side needs horizontal scrolling in the split document pane. This is one R1 success, not a three-case or general acceptance claim. E1 and D1 remain unrun. Cumulative usage is 40 hosted turns and 20 successful Jev calls.
  • Exact-head GitHub CI passed at b4047aeb: container, validation with unit and PostgreSQL tests, and browser integration. Browser E2E reported 476 passed, 5 skipped, and 2 flaky retries. The earlier head fd204251 also passed CI.
  • Focused tests: 79 passed; session boundary tests: 7 passed. bun run types and bun run ci passed. The ordinary default-off Planner prompt and instructions were verified byte-for-byte identical to the prior commit.

Prior guidance change

  • Add Chopin-owned Planner guidance for choosing source-grounded SeeCode diagrams and composing existing native document elements. The small addition gives process, comparison, and caveat recipes, with prose as a valid choice.
  • Add a loader-backed ten-case development cohort, a frozen five-case paired subset, and an opt-in runner that records real Planner tool actions, saved source, and browser reopen evidence.
  • Keep Markdown, allowlisted MDX, and ordinary ask decisions on the existing native authoring path. No new component or runtime is introduced.

Paired development result

The same frozen R1, A1, E1, D1, and S1 inputs ran once with the baseline guide and once with the candidate guide, using gpt-6-luna through Copilot SDK in fresh channels. Only the committed guidance and phase label changed. These were ten real Planner turns and zero Jev calls, with no case rerun for a better result.

E1 changed from dense prose to a legible Markdown table comparing the compatibility and CLI/inline coverage arguments. R1, A1, and D1 remained prose; S1 remained an ordinary ask. No diagram, Callout, or Tabs appeared in either arm. All ten documents saved and reopened without a render error. Both S1 questions added a fifth defer option beyond the four candidates named by the source. Rejected tool attempts were 4 in baseline and 7 in candidate; the small paired run does not establish that the guide caused this difference.

This is a five-case development diagnostic, not a general accuracy claim. The guide shows one useful local improvement and no clear broader shift.

Live R1 UI after repair

The reopened document shows the new explanation and the start of the flowchart; the split pane requires horizontal scrolling to see its right side.

R1 reopened Chopin document with an async-function flowchart in the split pane

Real UI after reopen

The comparison shows the actual authored E1 document section in the same browser layout before and after the guide change.

E1 reopened document before and after native composition guidance

Evaluation flow

Frozen five-case native Planner evaluation flow

Prior trial checks

  • Focused cohort and Planner instruction tests: 9 passed. The new table and Callout snippets pass dialect validation after the server-assigned Callout ID is added.
  • bun run types and bun run ci passed on the candidate commit; bun run fix applied and its diff was inspected.
  • Ten real Planner cases passed the save/reopen runner; separate AGENT=off browser passes showed the authored sections and S1 decisions after a fresh reopen.
  • GitHub CI passed at commit 8f445cc8: container build, validation, and browser integration.

Final integration validation: the feature was rebased onto merged main at 1d788ad7, with source identical to the verified combined branch. With Atomic 0.9.31 installed, the full unit suite passed (4,405 passed, four skipped), focused Atomic/visual/graph/connector tests passed (172 passed, one skipped), and bun run ci and bun run types passed. The merged connector change’s compact 390px touch Build regression passed. Earlier live R1 evidence retains its stated scope; this integration made no hosted Planner or Jev calls.

Landing corrections: the fake Jev browser regression now selects the exact accessible flowchart group, so the merged diagram toolbar icons do not make its SVG assertions ambiguous. Real Chromium reproduced the failure and passed after the test-only correction, retaining edit/save/reopen checks. CI fetches the same pinned Bun and PostgreSQL images through Google’s Docker Hub mirror after two confirmed anonymous pull-limit failures; both mirrored index digests matched Docker Hub. Every required test remains enabled and production container configuration is unchanged. Fresh full CI runs against 5df1105a.

@MaggieAppleton
MaggieAppleton force-pushed the maggie/seecode-document-diagrams branch from fbb37ff to 0cbfd1e Compare October 8, 2026 20:10
Base automatically changed from maggie/seecode-document-diagrams to main October 8, 2026 20:22
@MaggieAppleton MaggieAppleton changed the title Guide Planner visual authoring and exercise real acceptance cases Guide Planner native visual authoring and freeze acceptance cases Oct 9, 2026
@MaggieAppleton MaggieAppleton changed the title Guide Planner native visual authoring and freeze acceptance cases Guide Planner native document composition with paired evidence Oct 9, 2026
@MaggieAppleton
MaggieAppleton marked this pull request as ready for review October 9, 2026 12:03
@MaggieAppleton MaggieAppleton changed the title Guide Planner native document composition with paired evidence Route Planner visual authoring through Jev Oct 9, 2026
@MaggieAppleton
MaggieAppleton enabled auto-merge (rebase) October 9, 2026 16:52
@MaggieAppleton
MaggieAppleton force-pushed the maggie/planner-visual-authoring branch 2 times, most recently from 5a13eda to c782385 Compare October 9, 2026 18:15
@MaggieAppleton
MaggieAppleton force-pushed the maggie/planner-visual-authoring branch from c782385 to bd786af Compare October 9, 2026 20:36
@MaggieAppleton
MaggieAppleton merged commit 181b606 into main Oct 9, 2026
3 checks passed
@MaggieAppleton
MaggieAppleton deleted the maggie/planner-visual-authoring branch October 9, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant