Repository navigation
Renew design exceptions after the image node comment - #443
Merged
Merged
Conversation
`bun run ci` failed on main because the design contract reported the three reviewed dynamic owners in packages/dialect/src/nodes/content.ts as changed. Their group pins the whole owner file by SHA-256, and accc1ee rewrote only the ImageNode doc comment, which shifted that hash. Re-inspected each owner: CodeBlockNode, MathNode and FootnoteDefinitionNode createDOM still assign config.theme.planCode, planMath and planFootnote with their literal fallbacks, unchanged by the comment edit. Only the group's sourceHash is renewed; the cases, counts and reason are unchanged. Assistant-model: Claude Opus 5.5 (fast) Assistant-workflow: inline (worker subagent on anthropic-api/claude-opus-5-5-fast) Assistant-verification: bun scripts/check-design-contract.ts before the fix: exit 1 with the three CI errors Assistant-verification: bun run ci: exit 0 (design contract ok, 302 exact reviewed exceptions) Assistant-verification: bun test scripts/design-contract: 44 pass, 0 fail Assistant-verification: bunx dprint check on the changed manifest: exit 0 User-preference: Fix failing Chopin CI and open a PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainfails at "Format, lint, and enforce design tokens" (run 37997810458):Why
#442 (
accc1ee) changed only the doc comment aboveImageNodeinpackages/dialect/src/nodes/content.ts. The design contract pins a reviewed dynamic-exception group to its whole owner file by SHA-256 (sourceHash, seedocs/design-contract.md), so the comment edit invalidated the review of that file's three dynamic class names. My mistake: I ran dprint on #442 but notbun run ci.Review and renewal
I re-inspected the data flow of each reviewed owner. Each sets a block's class name from the Lexical theme with a fixed fallback, and none changed (the line numbers didn't move either):
CodeBlockNode.createDOMdom.className = config.theme.planCode ?? "planCode"MathNode.createDOMdom.className = config.theme.planMath ?? "planMath"FootnoteDefinitionNode.createDOMdom.className = config.theme.planFootnote ?? "planFootnote"The only change is that group's
sourceHashinscripts/design-contract/exceptions/dynamic-packages.json, from7f24fc5d…1beftofca5e0a9…e070(the current file's SHA-256). Cases, counts, reason and the check are unchanged.Verification
bun scripts/check-design-contract.tsreproduces the same three errors (exit 1).bun run ciexits 0: "design contract ok — 826 sources; 302 exact reviewed exceptions". oxlint reports the same 31 warnings as before and 0 errors.bun test scripts/design-contract: 44 pass, 0 fail.bunx dprint checkon the changed manifest: exit 0.Separately, the earlier red run on
e857cbb(#440) failed when the container job couldn't reach Docker Hub (auth.docker.io), not in code. The Docker Hub mirror commit onmaincovers that.Assistant-model: Claude Opus 5.5 (fast)
Assistant-workflow: inline (worker subagent on anthropic-api/claude-opus-5-5-fast)
Assistant-duration: 9m converged, estimated 15m
Assistant-verification: design contract passed: bun scripts/check-design-contract.ts reproduces the 3 errors before, bun run ci exits 0 after
Assistant-verification: bun test passed: scripts/design-contract (44 pass, 0 fail)
Assistant-verification: dprint passed: changed manifest
User-preference: Fix failing Chopin CI and open a PR