Repository navigation
Teach the Planner its existing numerical chart capabilities - #447
Open
MaggieAppleton wants to merge 4 commits into
Open
MaggieAppleton wants to merge 4 commits into
MaggieAppleton wants to merge 4 commits into
Conversation
|
The preview deployment for chopin is ready. 🟢 Open app | Open Build Logs | Open Application Logs Last updated at: 2026-10-10 08:53:24 CET |
MaggieAppleton
enabled auto-merge (rebase)
October 10, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Planner could deny all numerical chart support even though the deployed editor rendered it. Ordinary instructions named only three SeeCode diagram types, and the model also mistook a saved
codeblock for an unrendered chart.Expose the existing registry-derived catalogue (42 types and 15 aliases) to ordinary and Atomic Planner sessions, add labelled synthetic bar, Marimekko and dumbbell examples, variant-specific data requirements, and numeric evidence rules, and explain the canonical code-block representation. Prefer Chopin’s native SeeCode package whenever its catalogue can represent the information. Mermaid is only a fallback for a representation the native catalogue cannot provide or an explicit user request. Jev-selected diagrams remain SeeCode-only. Routing, flags, rendering and persistence are unchanged.
Validation: inventory, preference and alias-example regressions failed before their respective fixes. At
a0910d48, 28 focused Planner/catalogue/renderer tests pass (719 expectations), including all six actual guide examples and all 15 renderer aliases.bun run fix,bun run ciandbun run typespass (31 existing lint warnings). The precedinga752c4b2also passed 118 focused tests, including all 42 canonical edit/reopen cases. Current-head validation, e2e and container CI are pending.Review repair: aliases are no longer described as interchangeable canonical payloads.
marimekkorequires columns with segments;dumbbellrequires two values per category. The guide explains their purpose and input requirements with renderer-validated examples, and records the other numerical variants' meaning (such as ranks, bubble size and beeswarm packing). Canonical Jev selection criteria remain unchanged.Production reproduction, before this fix: two hosted turns first refused charts, then saved an explicitly supplied bar chart with Alpha 12, Beta 7, Gamma 19. A fresh browser tab rendered those exact values.
Chart-awareness acceptance at
fcc1bda9, local: one fresh realgpt-6-lunaCopilot SDK turn chose and saved a native bar chart without chart syntax or type hints. It preserved a different synthetic dataset—North 17, South 9, East 23, West 14—and the saved source and rendered values survived a fresh browser context and server restart. This used production Chat/document/persistence code with synthetic GitHub boundaries and Jev off. The later native-first preference and alias guidance are covered by deterministic tests and have no additional live-model run. No deployment or merge was performed.The trace retains a blocked repository-search attempt and an invalid insert index corrected within the same turn. A diagnostic SVG selector also matched toolbar icons; read-only recapture with the agent disabled passed. No further model turn was sent. This verifies the chart-awareness repair for one fresh case, not flawless tool use or all chart types in a live model.
What changes and what already worked
Corrected guidance: saved chart after fresh reopen
Real local-model output at
fcc1bda9, before the native-first and alias-guidance follow-ups, on fresh synthetic data. Capture followed server restart with the agent disabled; Fit to width shows all four bars.