Repository navigation
Move granted scopes, configuration and profile into the snapshot - #651
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors GIDGoogleUser to include grantedScopes, configuration, and profile in the immutable GIDGoogleUserTokens snapshot, resolving data races and ensuring consistent KVO notifications. The configuration is now computed once and remains fixed for the user's lifetime, and unit tests have been added to verify these behaviors. The review feedback suggests improving the change detection logic in updateTokensWithAuthState: by using isEqual: instead of pointer comparison for the profile object to prevent redundant updates, and optimizing the scopes comparison with a pointer equality fast path.
w-goog
commented
Oct 15, 2026
w-goog
added this pull request to stack #654
October 15, 2026 22:48
w-goog
force-pushed
the
fix/googleuser-snapshot-scopes-config-profile
branch
from
October 15, 2026 23:11
6192c1e to
410ed2c
Compare
yalkhder
reviewed
Oct 16, 2026
yalkhder
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grantedScopes,configuration, andprofileto the token snapshot. With this change, readers can no longer see new profile + old tokens.profilenow sends KVO notifications when it changes (it sent none before).configurationis now fixed at user creation. This closes a gap where GTMAppAuth refreshes may accidentally overwrite theaudienceoropenid.realmwith empty values. I'll fully address the remaining gap inrestorePreviousSignInin a future PR.