Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
941d9e8 to
b13dfc6
Compare
|
Hi @quifox, thank you for your contribution! We appreciate you taking the time to submit this pull request. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you. |
|
Thanks @quifox — SkillToolset never registers run_skill_script, so step 4 was sending the model to a tool that doesn't exist. One request: the scripts/ bullet still says "Executable scripts that can be run via bash", which makes the same promise without naming a tool. ADK Python swaps that bullet when script execution is unavailable; could you use the same text? - Optional: the class Javadoc ("list, load, and run skills") and the one-arg constructor Javadoc ("default execution settings") also mention running scripts. |
b13dfc6 to
9d68053
Compare
Description of Change
Problem:
SkillToolsetregisterslist_skills,load_skill, andload_skill_resource, but its default guidance advertisesrun_skill_scriptand describes scripts as executable through bash. Its class and constructor Javadocs also imply execution support that the toolset does not provide.Solution: Remove the unregistered-tool instruction and use ADK Python's guidance for unavailable script execution: scripts can be read with
load_skill_resourceand followed by the model. Update the Javadocs to describe listing skills and loading their instructions and resources. Custom system instructions retain their existing behavior.The regression test compares tool names in the default instruction with the registered tools and checks that the script guidance describes unavailable execution without advertising bash support.
Reference: ADK Python's script guidance.
Testing Plan
Unit Tests:
Java 17, with Google Java formatting enabled:
mvn -B -ntp -pl core -Dfmt.skip=false -Dtest=SkillToolsetTest -Dsurefire.failIfNoSpecifiedTests=false testThe strengthened regression fails against the previous guidance (6 tests, 1 failure, 0 errors). With the revised guidance,
SkillToolsetTestpasses all 6 tests in each of thedefault-testandbasicexecutions, with 0 failures, errors, or skips. These two executions run the same suite. The additional configured Surefire executions also complete successfully.Manual End-to-End (E2E) Tests: Not run against a live model provider. The tests exercise the toolset's injected system instruction and the actual tools returned by
getTools(), including the existing custom-instruction coverage.Checklist
No script-execution tool, dependency, or public API is added.