You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix for #5214 was overwritten by subsequent commit and remains an issue #5541
Issue described in #5214 persists. I get this is the era of slop, but this relatively minor fix required significant validation and testing. Please address.
@ASRagab You're right — commit 67dc2eb (a live/streaming refactor merged right after your PR) accidentally overwrote the fix from #5215, and that's entirely on us.
Sorry about that, you shouldn't have to re-address this.
As a workaround while the team re-applies the patch internally, could you try making expected_invocation: Optional[Invocation] = None at line 93 and adding the three if expected_invocation else None guards in _print_details (lines 439–449), and let us know if that clears things up on your end?
No need to raise another PR — once you confirm the workaround holds, we'll take care of getting it back into main!
sorry about the regression, the patch was re-applied in 8788d1c and shipped in v1.32.0. expected_invocation is Optional again on main and every read is guarded. open a new issue if it resurfaces.
Activity
ASRagab commentedon Apr 29, 2026
Thank you for reopening. The issue persists exactly as reported in #5214 in 2.31.1 (latest release)
surajksharma07 commentedon Apr 29, 2026
@ASRagab You're right — commit 67dc2eb (a live/streaming refactor merged right after your PR) accidentally overwrote the fix from #5215, and that's entirely on us.
Sorry about that, you shouldn't have to re-address this.
As a workaround while the team re-applies the patch internally, could you try making expected_invocation: Optional[Invocation] = None at line 93 and adding the three if expected_invocation else None guards in _print_details (lines 439–449), and let us know if that clears things up on your end?
No need to raise another PR — once you confirm the workaround holds, we'll take care of getting it back into main!
surajksharma07 commentedon Apr 29, 2026
@ankursharmas Please have a look into it once.
GWeale commentedon Aug 6, 2026
sorry about the regression, the patch was re-applied in 8788d1c and shipped in v1.32.0. expected_invocation is Optional again on main and every read is guarded. open a new issue if it resurfaces.