Activity

1. adk-bot

   assigned

   sanketpatil06

   on Jun 4, 2026
2. adk-bot

   added the

   Bug

   issue type on Jun 4, 2026
3. adk-bot commented on Jun 4, 2026

   

   adk-bot

   on Jun 4, 2026

   Collaborator

   More actions

   GitHub Issue #5963 Analysis: pre-commit check frequently fails on Copybara pushes to main, blocking external contributors

   Detailed Analysis

   1. Root Cause Analysis ("What is broken?")

   The ADK-Python repository utilizes a GitHub Actions workflow defined in pre-commit.yml which executes pre-commit/action@v3.0.1. By default, this action runs:
   pre-commit run --all-files
   under both push and pull_request triggers to verify compliance with the formatting and style rules defined in .pre-commit-config.yaml.

   The breakdown occurs due to a mismatch between Google's internal pipeline and the open-source GitHub workflow:

   1. Direct Pushes to Main: The Google-internal repository changes are pushed directly to main via copybara-service automation.
   2. Formatting Bypassed: This automated export/sync pipeline often bypasses or incorrectly formats Python files, neglecting rules specified in .pre-commit-config.yaml (such as Google-style pyink formatting or isort sorting).
   3. Failing Checks on Main: Direct pushes trigger the Pre-commit Checks on push. Since style violations are present, the CI check fails (resulting in 90+ informational failures on main), but since it's a direct push, it doesn't block the commit itself.
   4. Blocking PR Contributors: When external contributors open a PR touching any files, the workflow runs on the pull_request event. Because the pre-commit action runs --all-files, it runs on the entire repo including the misconfigured files on main, failing the contributor's PR CI check despite their own changes being perfectly formatted.

   2. Legitimacy Analysis

   • Status: Legitimate Bug / Infrastructure Flaw
   • Evidence:
     • CI execution uses pre-commit.yml, running pre-commit/action@v3.0.1 (which defaults to scanning --all-files).
     • Strict formatters are enforced in .pre-commit-config.yaml (isort, pyink).
     • Example failures occur in:
       • base_llm_flow.py
       • basic.py
       • gemini_llm_connection.py
       • test_base_llm_flow.py
       • test_gemini_llm_connection.py
     • This is verified by PR #5962, where the author successfully resolves the current failure by running manual formatting on those specific files.

   3. Fix Recommendation

   • Recommendation: Should Fix (High Priority) / Pipeline Configuration Fix
   • Rationale:
     • Impact: High. It adds significant friction to external collaboration. Contributors find their PRs blocked by unrelated style violations on the main branch.
     • Solution Strategy:
       1. Short-Term Workaround: Merge PR #5962 to immediately clean formatting in current files and unblock all pending and newly opened PRs.
       2. Long-Term Corrective Action: Update Google's internal Piper/Copybara sync pipeline to automatically execute isort and pyink formatting on outgoing Python files before pushing them to GitHub.
       3. Alternative CI Refactoring: Alternatively, the pre-commit workflow could be refactored to limit execution to changed files only on Pull Requests (e.g. using extra_args). However, correcting formatting at the Copybara boundary is the preferred architectural solution to maintain clean code and prevent style drift.

   4. Existing Pull Requests

   • Linked PR: Pull Request #5962 - fix: Python formatting (State: open)
   • PR URL: fix: Python formatting #5962
   • Analysis: Opened by the same author to fix the current formatting failures in the repository by running isort and pyink on the 5 affected files. It successfully restores formatting cleanliness but is only an immediate fix; future Copybara synchronization commits could re-introduce formatting discrepancies.

   ---

   Executive Summary

   1. What is broken? Style checks in GitHub CI fail on external PRs because direct main branch syncs via copybara-service bypass style formatting, and pre-commit scans all files in the repository.
   2. Is the issue legitimate? Yes, it is a legitimate infrastructure issue that blocks external contributors from successfully passing pre-commit CI validations.
   3. Should we fix it? Yes, High Priority. The immediate files should be reformatted by merging PR #5962, and the Copybara pipeline should be configured to run formatters on outgoing code.
   4. Is there a linked PR that fixes this issue? Yes, PR #5962 resolves the immediate styling issue, currently awaiting review from maintainers.

   ---

   Summary of Work Done

   • Retrieved issue details for GitHub Issue pre-commit check frequently fails on Copybara pushes to main, blocking external contributors #5963.
   • Searched active PRs and retrieved PR fix: Python formatting #5962 details.
   • Inspected the repository's .pre-commit-config.yaml and pre-commit workflow .github/workflows/pre-commit.yml.
   • Conducted root cause analysis on how copybara-service direct pushes create a discrepancy with --all-files pre-commit checks on external PR branches.
   • Produced a high-quality read-only investigation report detailing results and recommendations.
4. adk-bot

   added

   core[Component] This issue is related to the core interface and implementation[Component] This issue is related to the core interface and implementation

   on Jun 4, 2026
5. DeanChensj commented on Jun 9, 2026

   

   DeanChensj

   on Jun 9, 2026

   Collaborator

   More actions

   Thanks for reporting this, we have enforced the pre-commit check internally

   👍React with 👍1Reacted by Slava Primenko
6. DeanChensj

   closed this as completedon Jun 9, 2026