FirestoreSessionService.list_sessions(user_id="") returns every user's sessions #7662

import asyncio
from unittest import mock

from google.adk.integrations.firestore.firestore_session_service import FirestoreSessionService


def doc(data):
  snapshot = mock.MagicMock(exists=True)
  snapshot.to_dict.return_value = data
  return snapshot


async def main():
  client = mock.MagicMock()
  # Sessions of two other users, returned by the all-users collection_group query.
  client.collection_group.return_value.where.return_value.get = mock.AsyncMock(
      return_value=[
          doc({"id": "s-alice", "appName": "app", "userId": "alice", "state": {}}),
          doc({"id": "s-bob", "appName": "app", "userId": "bob", "state": {}}),
      ]
  )
  # Every per-user lookup (sessions of user "", app and user state) is empty.
  any_ref = client.collection.return_value.document.return_value
  any_ref.get = mock.AsyncMock(return_value=mock.MagicMock(exists=False))
  user_ref = any_ref.collection.return_value.document.return_value
  user_ref.get = mock.AsyncMock(return_value=mock.MagicMock(exists=False))
  user_ref.collection.return_value.where.return_value.get = mock.AsyncMock(
      return_value=[]
  )

  async def get_all(refs):
    for _ in refs:
      yield mock.MagicMock(exists=False)

  client.get_all = get_all

  service = FirestoreSessionService(client=client)
  response = await service.list_sessions(app_name="app", user_id="")
  print(
      [(s.user_id, s.id) for s in response.sessions],
      "collection_group used:",
      client.collection_group.called,
  )


asyncio.run(main())