Skip to content

feat: honor ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS - #5124

Closed
jinnigu wants to merge 1 commit into
google:mainfrom
jinnigu:feature/suppress-experimental-warnings
Closed

jinnigu wants to merge 1 commit into
google:mainfrom
jinnigu:feature/suppress-experimental-warnings

Conversation

@jinnigu

@jinnigu jinnigu commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

2. Or, if no issue exists, describe the change:

Problem:
ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS did not suppress all ADK
experimental warnings consistently. In practice, some experimental warnings
still appeared even when the env var was set, including the A2A flow described
in #5114.

Solution:
Make experimental warning suppression consistent across the affected ADK warning
paths.

  • The general env var now suppresses both registry-backed and decorator-based
    experimental warnings.
  • The existing A2A-specific env var continues to work for A2A warnings.
  • WIP warnings remain unchanged.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Coverage added / verified for:

  • general experimental-warning suppression behavior
  • feature-registry-backed experimental warnings
  • decorator-based experimental warnings
  • A2A warnings with both the general env var and the A2A-specific env var
  • non-regression for existing utils decorator behavior

Manual End-to-End (E2E) Tests:

Verified in a Python 3.11 environment that both A2A and registry-backed
experimental warnings are suppressed when ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS=1
is set, and that the A2A-specific env var still works independently.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

  • This fix is scoped to ADK experimental warning suppression.
  • WIP warnings are intentionally unchanged.
  • The A2A-specific suppression env var remains supported for backward
    compatibility.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Apr 3, 2026
@jinnigu
jinnigu force-pushed the feature/suppress-experimental-warnings branch 3 times, most recently from 2d26241 to 8e97e24 Compare April 3, 2026 08:22
@jinnigu jinnigu changed the title feat: ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS not working feat: honor ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS Apr 3, 2026
@rohityan rohityan self-assigned this Apr 6, 2026
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @jinnigu , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. Can you also ensure the other failing tests are also fixed

@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label Apr 13, 2026
@jinnigu
jinnigu force-pushed the feature/suppress-experimental-warnings branch from 98cd4dd to 52127cf Compare April 14, 2026 07:21
@jinnigu

jinnigu commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi @jinnigu , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. Can you also ensure the other failing tests are also fixed

Thanks @rohityan for helping review. The PR is now synced and reformatted.

copybara-service Bot pushed a commit that referenced this pull request Oct 16, 2026
Merge #5124

Fixes #5114

PiperOrigin-RevId: 1000995317
@adk-bot

adk-bot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Thank you @jinnigu for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit b592dee.

Closing this PR as the changes are now in the main branch.

@adk-bot adk-bot added the merged [Status] This PR is merged label Oct 16, 2026
@adk-bot adk-bot closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation merged [Status] This PR is merged request clarification [Status] The maintainer need clarification or more information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADK_SUPPRESS_EXPERIMENTAL_FEATURE_WARNINGS not working

3 participants