[giulio-leone]

Summary

Fixes #5186.

convert_a2a_message_to_event() hard-coded role='model' on the GenAI Content it produced, ignoring the A2A Message.role field. This caused Role.user messages to be restored as model events.

Additionally, the task-history fallback in convert_a2a_task_to_event() (in event_converter.py) blindly took history[-1] without checking Message.role, so a trailing user message could be misattributed as agent output.

Root Cause

• event_converter.py: Content(role="model", ...) was hard-coded in two places inside convert_a2a_message_to_event().
• to_adk_event.py: _create_event() hard-coded role="model" with no way to override.
• event_converter.py: convert_a2a_task_to_event() fallback path used a2a_task.history[-1] unconditionally.

Changes

File	Change
converters/utils.py	New a2a_role_to_genai_role() helper (Role.agent→"model", Role.user→"user")
converters/event_converter.py	Use helper in convert_a2a_message_to_event(); filter history fallback to agent-role messages only
converters/to_adk_event.py	Add role param to _create_event(); pass mapped role from convert_a2a_message_to_event()
test_event_converter.py	Regression tests for role mapping + history fallback
test_to_adk.py	Regression tests for role mapping
test_utils.py	Unit tests for a2a_role_to_genai_role()

Testing

All 86 converter tests pass (test_event_converter.py, test_to_adk.py, test_utils.py).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[adk-bot]

Response from ADK Triaging Agent

Hello @giulio-leone, thank you for creating this PR!

Before we can review your contribution, could you please sign our Contributor License Agreement (CLA)? You can find more information at https://cla.developers.google.com/.

Additionally, since this PR is a bug fix, could you please provide logs or a screenshot demonstrating that the fix is working as expected? This will help the reviewers to better understand and verify your changes.

Thank you!

[giulio-leone]

Added focused regression coverage for the fix:

• test_event_converter.py: verifies Role.user is restored as user and that task-history fallback ignores trailing user messages
• test_to_adk.py: verifies inbound event conversion preserves the mapped role
• test_utils.py: verifies a2a_role_to_genai_role() mappings

Local result: 86 converter tests passed (test_event_converter.py, test_to_adk.py, test_utils.py).

This reproduces the original bug path and confirms that user-role messages are no longer misattributed as model output.

[rohityan]

Hi @giulio-leone , Thank you for your contribution! We appreciate you taking the time to submit this pull request.
Please fix formatting errors by running autoformat.sh

[giulio-leone]

Rebased onto the current main, ran ./autoformat.sh, and kept the final diff scoped to the PR file (src/google/adk/a2a/converters/event_converter.py).

Local revalidation after the rebase:

• isort --check on the 6 touched converter files
• pyink --check --diff --config pyproject.toml on the same 6 files
• PYTHONPATH=$PWD/src python -m pytest tests/unittests/a2a/converters/ → 154 passed

I also rechecked the role-conversion path locally to confirm the behavior is still intact after the formatting-only update: Role.user stays user, Role.agent stays model, and task-history fallback still ignores trailing user messages.

[adk-bot]

Thank you @giulio-leone for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 968845f.

Closing this PR as the changes are now in the main branch.