Repository navigation
Conversation
Refactor blob path handling to prevent path traversal vulnerabilities.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
adk-bot
added
the
core
Added path traversal protection in _materialize_and_run function.
Added checks for absolute paths and updated path traversal detection.
Refactor _load_files_in_dir to use dict type hints and PurePosixPath for path validation.
|
"Updated PR #5281 — defense in depth implemented. Both ingestion-time (_utils.py via PurePosixPath) and execution-time (skill_toolset.py via realpath + commonpath) protections verified locally against original PoC. Malicious paths blocked at source before execution. Safe paths unaffected." |
rohityan
added
the
request clarification
|
Hi @Bisht-cx , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
|
sure , lemme start working on it , will update in few minutes / hours |
|
Done! Ran autoformat.sh pyink and isort fixes are pushed. Checks should be green now. |
|
@rohityan
The fix ensures malicious blob paths cannot escape the intended directory before execution. Would appreciate a review when you get time. Thanks! |
|
"@rohityan all conflicts resolved and checks are green. This PR patches a triaged unauthenticated RCE (Google OSS VRP #499557362) — path traversal via unsanitized GCS blob names leading to runpy.run_path() execution. Would appreciate workflow approval and review when you get a chance. Planned disclosure date is July 3, 2026." |
- Ingestion layer: reject .. traversal, absolute paths, duplicate normalized paths - Materialization layer: verify realpath+commonpath guards block traversal and absolute paths - Happy path: confirm safe blobs load and materialize correctly
bishtsec
left a comment
bishtsec
left a comment
There was a problem hiding this comment.
@surajksharma07 — E2E verification is complete as requested. All 108 tests pass as of commit d340122 (today). Both defense layers confirmed, formatting clean.
One blocker remaining: 4 workflows are pending maintainer approval to run CI — could you approve the workflow run so checks can complete?
Merge #5281 PiperOrigin-RevId: 1000940892
|
Thank you @cherry-bisht for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 20a5a0c. Closing this PR as the changes are now in the main branch. |
closed issue